[wasm] Add support for symbolicating native traces from JS, using a symbols file #66042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
.. warnings. The regex patterns are hardcoded in `debug.ts`. And the symbols are loaded from `dotnet.js.symbols`. We try to symbolicate wherever possible.
radical
force-pushed
the
symbolicate-from-js
branch
from
12e529d to
05a1c66
Compare
pavelsavara
reviewed
Mar 2, 2022
|
In the future we could also add symbols to stack traces which are marshaled as C# exception. runtime/src/mono/wasm/runtime/method-calls.ts Line 459 in 842f4d7 |
pavelsavara
reviewed
Mar 2, 2022
.. and use that to symbolicate traces marshaled as C# exceptions (thanks to @pavelsavara for the suggestion).
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
approved these changes
Mar 3, 2022
|
Test failures are unrelated. |
radekdoulik
reviewed
Oct 11, 2023
| @@ -39,7 +39,7 @@ run-browser: | |||
| fi | |||
|
|
|||
| run-console: | |||
| cd bin/$(CONFIG)/AppBundle && $(V8_PATH) --stack-trace-limit=1000 --single-threaded --expose_wasm $(MAIN_JS) -- $(DOTNET_MONO_LOG_LEVEL) --run $(CONSOLE_DLL) $(ARGS) | |||
There was a problem hiding this comment.
This broke browser-bench's make run for console version. Why was --run $(CONSOLE_DLL) removed? Do I need to update browser-bench's Makefile somehow?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug.js.symbolsis loaded from the vfs