[wasm] Add support for symbolicating traces via XHarness #66226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Needs dotnet/xharness#830 to be merged first.
|
- this can be used to symbolicate traces using patterns from `src/mono/wasm/data/wasm-symbol-patterns.txt`. - Includes a wrapper that can be passed to xharness for symbolicating traces in the output. - This can be used as a command line tool also: `dotnet run /path/to/dotnet.js.symbols /path/to/traces` If `-` is passed instead of the last argument, then it reads the messages from stdin.
radical
force-pushed
the
symbolicate-xharness
branch
from
fd4e890 to
f7e97da
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
do we still want to take this? |
|
I think it's useful. |
maraf
approved these changes
May 19, 2022
lewing
approved these changes
May 25, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Revert unnecessary change
Revert unnecessary change
Revert unnecessary change
|
The coreclr failure is #70112 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/mono/wasm/symbolicatorproject