Add ItemTemplates for Razor Pages #566

rynowak · 2017-04-11T22:24:34Z

rynowak · 2017-04-11T22:25:18Z

...ft.DotNet.Common.ItemTemplates/content/RazorPageWithPageModel/.template.config/template.json

+{
+  "author": "Microsoft",
+  "classifications": ["Web", "ASP.NET"],
+  "name": "Razor Page with Page Model",


@DamianEdwards @Eilon - do the branding thing plz

rynowak · 2017-04-11T22:26:04Z

...ft.DotNet.Common.ItemTemplates/content/RazorPageWithPageModel/.template.config/template.json

+  "groupIdentity": "Microsoft.AspNetCore.Mvc.RazorPageWithPageModel",
+  "precedence": "100",
+  "identity": "Microsoft.AspNetCore.Mvc.RazorPageWithPageModel",
+  "shortName": "page",


Ideas about a short name to distinguish this from pages (without pagemodel)??

We also have the option to make this a single item and have another parameter to distinguish.

I'd advocate for making these into a single template with a distinguishing param, maybe something like:

"model": { "type": "parameter", "datatype": "bool", "defaultValue": "false", "description": "<insert appropriate desc. here>" }

I'll give this a try thanks

rynowak · 2017-04-11T22:26:19Z

template_feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPageWithPageModel/Index.cs

+using Microsoft.AspNetCore.Mvc;
+using Microsoft.AspNetCore.Mvc.RazorPages;
+
+namespace MyApp.Namespace


This does the right thing. Relax.

seancpeters · 2017-04-12T00:13:19Z

...ft.DotNet.Common.ItemTemplates/content/RazorPageWithPageModel/.template.config/template.json

+  "primaryOutputs": [ { "path": "Index.cshtml"}, { "path": "Index.cs" } ],
+  "defaultName": "Index",
+  "symbols": {
+    "namespace": { 


It's probably good to add a description to the namespace symbol, it'll get displayed in the detailed help for the template in the CLI.

Eilon

Tentative-approval. Others will need to approve other stuff.

Eilon · 2017-04-12T01:57:10Z

...ft.DotNet.Common.ItemTemplates/content/RazorPageWithPageModel/.template.config/template.json

+{
+  "author": "Microsoft",
+  "classifications": ["Web", "ASP.NET"],
+  "name": "Razor Page with Page Model",


Eilon · 2017-04-12T01:57:58Z

template_feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPageWithPageModel/Index.cs

+using System.Linq;
+using System.Threading.Tasks;
+using Microsoft.AspNetCore.Mvc;
+using Microsoft.AspNetCore.Mvc.RazorPages;


Is this a good default set of namespaces? Anything else common that should go here? (Not at all saying it isn't, I'm just not familiar with what's generally used.)

For templates, we generally only include the usings that are required by the generated template code. But I could see including additional usings that most users would end up adding as they modify the content.

This is the same set of namespaces that the template uses for HomeController with the Microsoft.AspNetCore.Mvc.RazorPages namespace added (required).

This looks good to me then.

Eilon · 2017-04-12T01:58:58Z

template_feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPageWithPageModel/Index.cs

+    {
+        public void OnGet()
+        {
+


Whitespace? Is this a joke?

rynowak · 2017-04-12T21:30:26Z

..._feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPage/.template.config/template.json

+  "sources": {
+    "modifiers": [
+      {
+        "condition": "(no-pagemodel)",


@seancpeters - this isn't working. I've tried some stuff and it still wants to output the Index.cs file.

I screwed up the syntax when we were chatting. Sources should be like this:

"sources": [ { "modifiers": [ { "condition": "(no-pagemodel)", "exclude": [ "Index.cs" ] } ] } ],

DamianEdwards

Should we add item templates for _ViewStart.cshmtl and _ViewImports.cshtml too?

DamianEdwards · 2017-04-12T21:57:31Z

template_feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPage/Index.cs

+
+namespace MyApp.Namespace
+{
+    public class Index : PageModel


Pls name this IndexModel and the file Index.cshtml.cs

DamianEdwards · 2017-04-12T21:58:42Z

template_feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPage/Index.cshtml

+@model Index
+@*#endif*@
+@{
+}


Don'twe usually include blank lines at the end of template files? I think it makes it easier to start adding HTML, etc.

I don't usually know. Added a blank line

seancpeters · 2017-04-12T22:08:40Z

..._feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPage/.template.config/template.json

+    ]
+  },
+  "symbols": {
+    "namespace": {


@rynowak - you had asked me about making a parameter required. You can add
"isRequired": "true"
... to the symbol definition to make it required.

Note: I'm tracking down a bug related to isRequired, so you may want to hold off on making that change.

Sure, I wasn't planning to do it for this change, I just wanted to know.

rynowak · 2017-04-12T22:11:28Z

Should we add item templates for _ViewStart.cshmtl and _ViewImports.cshtml too?

Sure, I'll do this in a follow up PR

rynowak · 2017-04-12T22:16:51Z

dotnet new page

Generates Page and PageModel, uses a placeholder namespace

dotnet new page --namespace MyCoolApp.MyCoolNamespace

Generates Page and PageModel, uses provided namespace

dotnet new page --no-pagemodel

Generates Page

seancpeters · 2017-04-12T22:26:00Z

..._feed/Microsoft.DotNet.Common.ItemTemplates/content/RazorPage/.template.config/template.json

+  "identity": "Microsoft.AspNetCore.Mvc.RazorPage",
+  "shortName": "page",
+  "sourceName": "Index",
+  "primaryOutputs": [ { "path": "Index.cshtml"}, { "path": "Index.cs" } ],


@rynowak - for adding conditions to primary outputs, the format is like this:

"primaryOutputs": [ { "path": "Index.cshtml" }, { "path": "Index.cs", "condition": "(!no-pagemodel)" } ]

If I understood correctly, that example should do what we talked about earlier.

rynowak · 2017-04-12T22:31:59Z

Updated

rynowak · 2017-04-14T20:15:55Z

@mlorbetske @seancpeters - Ping. this is ready to go

rynowak commented Apr 11, 2017

View reviewed changes

seancpeters reviewed Apr 12, 2017

View reviewed changes

Eilon approved these changes Apr 12, 2017

View reviewed changes

rynowak force-pushed the rynowak/razorpages branch from 87ea568 to 951743f Compare April 12, 2017 21:28

rynowak commented Apr 12, 2017

View reviewed changes

DamianEdwards reviewed Apr 12, 2017

View reviewed changes

seancpeters reviewed Apr 12, 2017

View reviewed changes

rynowak force-pushed the rynowak/razorpages branch from 22ccce8 to c8e600b Compare April 12, 2017 22:31

rynowak and others added 4 commits April 15, 2017 09:16

Add ItemTemplates for Razor Pages

b981e80

PR Feedback

5d8c654

Add web item templates project

56c499c

Move Razor Pages item templates to web item templates

0b2a60c

mlorbetske force-pushed the rynowak/razorpages branch from b7d681d to 0b2a60c Compare April 15, 2017 16:16

mlorbetske merged commit 597fcb0 into dotnet:rel/vs2017/post-rtw Apr 15, 2017

This was referenced Apr 17, 2017

Big Rock: Template work for Pages aspnet/Mvc#6086

Closed

Create Item Template for Page/PageModel aspnet/Mvc#6085

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ItemTemplates for Razor Pages #566

Add ItemTemplates for Razor Pages #566

rynowak commented Apr 11, 2017

rynowak Apr 11, 2017

Eilon Apr 12, 2017

rynowak Apr 11, 2017

seancpeters Apr 12, 2017 •

edited

Loading

rynowak Apr 12, 2017

rynowak Apr 11, 2017

seancpeters Apr 12, 2017

rynowak Apr 12, 2017

Eilon left a comment

Eilon Apr 12, 2017

Eilon Apr 12, 2017

seancpeters Apr 12, 2017

rynowak Apr 12, 2017

Eilon Apr 12, 2017

Eilon Apr 12, 2017

rynowak Apr 12, 2017

seancpeters Apr 12, 2017

DamianEdwards left a comment

DamianEdwards Apr 12, 2017

rynowak Apr 12, 2017

DamianEdwards Apr 12, 2017

rynowak Apr 12, 2017

seancpeters Apr 12, 2017

rynowak Apr 12, 2017

rynowak commented Apr 12, 2017

rynowak commented Apr 12, 2017

seancpeters Apr 12, 2017

rynowak commented Apr 12, 2017

rynowak commented Apr 14, 2017

Add ItemTemplates for Razor Pages #566

Add ItemTemplates for Razor Pages #566

Conversation

rynowak commented Apr 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seancpeters Apr 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eilon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DamianEdwards left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rynowak commented Apr 12, 2017

rynowak commented Apr 12, 2017

Choose a reason for hiding this comment

rynowak commented Apr 12, 2017

rynowak commented Apr 14, 2017

seancpeters Apr 12, 2017 •

edited

Loading