Merge pull request #2579 from rchande/handleEmptyTests

Handle empty tests
dotnet · Oct 4, 2018 · 030ec63 · 030ec63
2 parents 9fc3ad8 + da7b8e5
commit 030ec63
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/observers/DotnetTestLoggerObserver.ts b/src/observers/DotnetTestLoggerObserver.ts
@@ -72,7 +72,9 @@ export default class DotNetTestLoggerObserver extends BaseLoggerObserver {
     private handleReportDotnetTestResults(event: ReportDotNetTestResults) {
         this.logger.appendLine("----- Test Execution Summary -----");
         this.logger.appendLine('');
-        const results = event.results;
+
+        // Omnisharp returns null results if there are build failures
+        const results = event.results || [];
         const totalTests = results.length;
 
         let totalPassed = 0, totalFailed = 0, totalSkipped = 0;

diff --git a/test/unitTests/logging/DotnetTestLoggerObserver.test.ts b/test/unitTests/logging/DotnetTestLoggerObserver.test.ts
@@ -107,6 +107,11 @@ suite(`${DotNetTestLoggerObserver.name}`, () => {
                 result.StandardError.forEach(message => expect(appendedMessage).to.contain(message));
             });
         });
+
+        test(`Can handle malformed results`, () => {
+            observer.post(new ReportDotNetTestResults([]));
+            expect(appendedMessage).to.contain("----- Test Execution Summary -----\n\nTotal tests: 0. Passed: 0. Failed: 0. Skipped: 0");
+        });
     });
 });