Handle empty tests #2579
Merged
Handle empty tests #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2579 +/- ##
=========================================
- Coverage 64.62% 64.52% -0.1%
=========================================
Files 97 97
Lines 4251 4251
Branches 613 614 +1
=========================================
- Hits 2747 2743 -4
- Misses 1326 1328 +2
- Partials 178 180 +2
Continue to review full report at Codecov.
|
akshita31
reviewed
Oct 4, 2018
| @@ -72,7 +72,9 @@ export default class DotNetTestLoggerObserver extends BaseLoggerObserver { | |||
| private handleReportDotnetTestResults(event: ReportDotNetTestResults) { | |||
| this.logger.appendLine("----- Test Execution Summary -----"); | |||
| this.logger.appendLine(''); | |||
| const results = event.results; | |||
|
|
|||
There was a problem hiding this comment.
Do we want to print "Test Execution summary" and print "Total Tests:0" even if the results are null?
Should we do a null check instead and do not print anything instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with but probably not fix #2398