exec.Scanner: New exposed scanner supports iterative scanning #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Sep 16, 2019
A Scanner that is modeled after sql.Rows Next and Scan. This can be used when scanning one item at a time for better memory efficiency on large result sets.
|
Thanks for the contribution! I know not a lot of files were changed but they some of the more complex parts Give me a couple of days to go through them. |
|
Thanks @doug-martin! And thank you for an awesome package by the way! |
doug-martin
added a commit
that referenced
this pull request
Sep 23, 2019
Merged
|
@akarl I just opened v9.2.0 which has your changes in there! Great work diving in and figuring out how to add this. I changed a few things to clean up some code and removed some dead code paths. Awesome job! |
|
Awesome! Thank you! |
doug-martin
added a commit
that referenced
this pull request
Sep 23, 2019
doug-martin
added a commit
that referenced
this pull request
Sep 23, 2019
doug-martin
added a commit
that referenced
this pull request
Sep 23, 2019
doug-martin
added a commit
that referenced
this pull request
Sep 23, 2019
|
released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Scanner that is modeled after sql.Rows Next and Scan. This can be used when scanning one item at a time for better memory efficiency on large result sets.
I'm a bit unsure about the
db.From().Select().Executor().Scanner()way of getting it when coming from aSelectDatasetbut I think that this wouldn't be used so often as to warrant a method directly on theSelectDataset.Let me know what you think!