v9.2.0 #168
Merged
v9.2.0 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
doug-martin
commented
Sep 23, 2019
doug-martin
commented
- [ADDED] exec.Scanner: New exposed scanner supports iterative scanning exec.Scanner: New exposed scanner supports iterative scanning #157 - @akarl
A Scanner that is modeled after sql.Rows Next and Scan. This can be used when scanning one item at a time for better memory efficiency on large result sets.
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=========================================
+ Coverage 93.88% 94.09% +0.2%
=========================================
Files 56 56
Lines 3878 3876 -2
=========================================
+ Hits 3641 3647 +6
+ Misses 218 214 -4
+ Partials 19 15 -4
Continue to review full report at Codecov.
|
akarl
approved these changes
Sep 23, 2019
doug-martin
force-pushed
the
v9.2.0-rc
branch
from
da1d8e3 to
9cea586
Compare
golangcibot
reviewed
Sep 23, 2019
exec/query_executor_test.go
Outdated
| qes.NoError(err) | ||
|
|
||
| e := newQueryExecutor(db, nil, `SELECT * FROM "items"`) | ||
| sql, args, err := e.ToSQL() |
There was a problem hiding this comment.
importShadow: shadow of imported from 'database/sql' package 'sql' (from gocritic)
doug-martin
force-pushed
the
v9.2.0-rc
branch
2 times, most recently
from
7585896 to
102816b
Compare
doug-martin
force-pushed
the
v9.2.0-rc
branch
from
102816b to
9bf9a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.