Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90multipath: install multipathd.socket #2010

Merged
merged 1 commit into from
Oct 22, 2022
Merged

90multipath: install multipathd.socket #2010

merged 1 commit into from
Oct 22, 2022

Conversation

cthbleachbit
Copy link
Contributor

Changes

This pull request makes 90multipath module install multipathd.socket from system paths along side with the systemd service unit (which lists the socket as a dependency). Without the socket unit file, systemctl invoked by dracut may report failed to enable unit during generation, and the resulting initrd will not have a usable multipathd at early boot.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

@github-actions github-actions bot added modules Issue tracker for all modules multipath Issues related to the multipath module labels Oct 18, 2022
Copy link
Collaborator

@johannbg johannbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloGombos LaszloGombos enabled auto-merge (rebase) October 22, 2022 15:49
@mwilck
Copy link
Contributor

mwilck commented Mar 25, 2023

Next time please involve the multipath maintainers when you change the 90multipath module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Issue tracker for all modules multipath Issues related to the multipath module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants