Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis STREAM consumer group have duplicates #2294

Closed
kirinnee opened this issue Dec 12, 2023 · 1 comment · Fixed by #2323 or #2345
Closed

Redis STREAM consumer group have duplicates #2294

kirinnee opened this issue Dec 12, 2023 · 1 comment · Fixed by #2323 or #2345
Assignees
@BorysTheDev
Labels
bug Something isn't working

Comments

@kirinnee
Copy link

Describe the bug
Redis STREAM Consumer groups have duplicates

To Reproduce
Steps to reproduce the behavior:

  1. Start dragonflydb with docker
  2. Run 3 separate session of docker exec, docker exec -ti <container> redis-cli -a <password>
  3. In session 1: XGROUP CREATE pokenews pokenews-group 0 MKSTREAM
  4. In session 2: XREADGROUP GROUP pokenews-group ash COUNT 1 BLOCK 0 STREAMS pokenews >
  5. In session 3: XREADGROUP GROUP pokenews-group ash COUNT 1 BLOCK 0 STREAMS pokenews >
  6. In session 1: XADD pokenews * pokemon entei

both session 2 and session 3 receives the message.

Expected behavior
Only session 2 OR session 3 should receive the message, both of them are in the same consumer group

Environment (please complete the following information):

  • Host OS: MacOS 13.4.1
  • OS: ubuntu docker image
  • Containerized?: Docker, ghcr.io/dragonflydb/dragonfly:v1.13.0-ubuntu
  • Dragonfly Version: 1.13.0

Additional context
None
@kirinnee kirinnee added the bug Something isn't working label Dec 12, 2023
@BorysTheDev BorysTheDev self-assigned this Dec 12, 2023
@BorysTheDev
Copy link
Contributor

@kirinnee thx for reporting the bug, I've already reproduced it and will fix it soon.

BorysTheDev added a commit that referenced this issue Dec 20, 2023
@BorysTheDev
fix(stream): make fix for XREADBLOCK function
f874121 
partly fixes #2294
bug: id ">" means that the consumer want to receive only messages
that were never delivered to any other consumer

fix: added temporary tests results, the correct ones are commented out
until we fix the blocking mechanism. Fix requested range for blocking
operations
BorysTheDev added a commit that referenced this issue Dec 21, 2023
@BorysTheDev
fix(stream): make fix for XREADBLOCK function
c042972 
partly fixes #2294
bug: id ">" means that the consumer want to receive only messages
that were never delivered to any other consumer

fix: added temporary tests results, the correct ones are commented out
until we fix the blocking mechanism. Fix requested range for blocking
operations
@BorysTheDev BorysTheDev mentioned this issue Dec 21, 2023
Merged
BorysTheDev added a commit that referenced this issue Dec 22, 2023
@BorysTheDev
fix(stream): make fix for XREADBLOCK function (#2323)
1376295 
partly fixes #2294
bug: id ">" means that the consumer want to receive only messages
that were never delivered to any other consumer

fix: added temporary tests results, the correct ones are commented out
until we fix the blocking mechanism. Fix requested range for blocking
operations
@BorysTheDev BorysTheDev reopened this Dec 22, 2023
BorysTheDev added a commit that referenced this issue Dec 27, 2023
@BorysTheDev
fix: unblock transactions only if requirements are correct
1770502 
fixes #2294

bug: we unblock XREADGROUP cmd even if we don't have new values

fix: added check with custom requirements for blocking comands
@BorysTheDev BorysTheDev mentioned this issue Dec 27, 2023
Merged
BorysTheDev added a commit that referenced this issue Dec 27, 2023
@BorysTheDev
fix: unblock transactions only if requirements are correct
7306f24 
fixes #2294

bug: we unblock XREADGROUP cmd even if we don't have new values

fix: added check with custom requirements for blocking comands
BorysTheDev added a commit that referenced this issue Jan 2, 2024
@BorysTheDev
fix: unblock transactions only if requirements are correct
9dbd48d 
fixes #2294

bug: we unblock XREADGROUP cmd even if we don't have new values

fix: added check with custom requirements for blocking comands
BorysTheDev added a commit that referenced this issue Jan 2, 2024
@BorysTheDev
fix: unblock transactions only if requirements are correct
d368aed 
fixes #2294

bug: we unblock XREADGROUP cmd even if we don't have new values

fix: added check with custom requirements for blocking comands
BorysTheDev added a commit that referenced this issue Jan 2, 2024
@BorysTheDev
fix: unblock transactions only if requirements are correct (#2345)
5b90545 
fixes #2294

bug: we unblock XREADGROUP cmd even if we don't have new values

fix: added check with custom requirements for blocking comands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BorysTheDev BorysTheDev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@BorysTheDev @kirinnee