fix: unblock transactions only if requirements are correct #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Dec 27, 2023
src/server/blocking_controller.cc
Outdated
| do { | ||
| WatchItem& wi = queue.front(); | ||
| Transaction* head = wi.get(); | ||
| for (auto wi_it = queue.begin(), wi_e = queue.end(); wi_it != wi_e; ++wi_it) { |
There was a problem hiding this comment.
as I said before, I would like to preserve a simple and efficient case of lists, sorted sets notifying a single waiter and stop.
There was a problem hiding this comment.
I don't change the behaviour)
There was a problem hiding this comment.
Didn't get your message at first. let's check how this implementation works. I can implement your suggestion regarding different queues for list, zset and stream like an optimization,
romange
reviewed
Dec 27, 2023
romange
reviewed
Dec 27, 2023
BorysTheDev
force-pushed
the
fix_blocking_transactions
branch
2 times, most recently
from
489bfd9 to
54b891b
Compare
dranikpg
previously approved these changes
Dec 29, 2023
dranikpg
previously approved these changes
Dec 30, 2023
romange
reviewed
Dec 30, 2023
romange
reviewed
Dec 30, 2023
romange
reviewed
Dec 30, 2023
romange
reviewed
Dec 30, 2023
romange
reviewed
Dec 30, 2023
BorysTheDev
force-pushed
the
fix_blocking_transactions
branch
from
cf15451 to
72976f7
Compare
fixes #2294 bug: we unblock XREADGROUP cmd even if we don't have new values fix: added check with custom requirements for blocking comands
BorysTheDev
force-pushed
the
fix_blocking_transactions
branch
from
72976f7 to
d368aed
Compare
romange
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2294
bug: we unblocked XREADGROUP cmd even if we don't have new values
fix: added check with custom requirements for blocking commands