Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ZUNION command #356

Closed
romange opened this issue Oct 5, 2022 · 8 comments
Closed

Support ZUNION command #356

romange opened this issue Oct 5, 2022 · 8 comments
Labels
API-6 Redis 6 API enhancement New feature or request hacktoberfest Participates in Hacktoberfest

Comments

@romange
Copy link
Collaborator

romange commented Oct 5, 2022

See https://redis.io/commands/zunion for more details.

For external contributors: we will also accept the basic functionality without supporting of optional arguments.
@romange romange added API-6 Redis 6 API enhancement New feature or request hacktoberfest Participates in Hacktoberfest labels Oct 5, 2022
@ATM-SALEH
Copy link
Contributor

I can have a look into this

@matchyc
Copy link
Contributor

matchyc commented Oct 13, 2022

@romange Hi, I'm new here, a graduate student interested in DF! I have seen the primary codes for zset related commands, and trying to implement the function.
One question I met is that zunionstore is implemented by read->union->temporary map result->add to destkey such procedure. But Union does not require the last step, and we can send results back to the client after we got the intermediate result.
So what kind of method is wanted by community?
I'd like to propose two plans:

  • Implement a function like ToObject or ToScoredArray, which enable df to transform ScoredMap to ScoredArray and just call OutputScoredArrayResult.
  • Implement a function like OutputScoredMapResult, which requires allocating a ScoredArray in this function to get a sorted result.

Thanks for reading this

@ATM-SALEH
Copy link
Contributor

@matchyc - I started working on this feature. However, happy as well if you take over

@romange
Copy link
Collaborator Author

romange commented Oct 13, 2022

Hi @ATM-SALEH since you already started I think it makes sense that you continue...
There are enough tasks for everyone :)

@matchyc
Copy link
Contributor

matchyc commented Oct 13, 2022

@matchyc - I started working on this feature. However, happy as well if you take over

Just go on!

@romange
Copy link
Collaborator Author

romange commented Oct 19, 2022

hey @ATM-SALEH are you still working on it?

@ATM-SALEH
Copy link
Contributor

Yes - I started working on it. However, couldn't manage time to allocate this week. Hoping to wrap this up this weekend

@ATM-SALEH ATM-SALEH mentioned this issue Oct 22, 2022
Closed
adiholden added a commit that referenced this issue Jan 16, 2023
@adiholden
feat(zset family): fix PR #356
13c1f29 
Signed-off-by: adi_holden <[email protected]>
adiholden added a commit that referenced this issue Jan 17, 2023
@adiholden @ATM-SALEH
feat(zset family): implement a variant of ZUNION command issue #356 (#…
b2edf9c 
…686)


Signed-off-by: ATM SALEH <[email protected]>
Signed-off-by: adi_holden <[email protected]>
Co-authored-by: ATM SALEH <[email protected]>
@romange
Copy link
Collaborator Author

romange commented Feb 20, 2023

Fixed by #717

@romange romange closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API-6 Redis 6 API enhancement New feature or request hacktoberfest Participates in Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ATM-SALEH @romange @matchyc