fix(server): zunion now supports variadic arguments #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
VariadicZunion
branch
3 times, most recently
from
9ca9745 to
9ccad8b
Compare
adiholden
reviewed
Jan 23, 2023
| EXPECT_THAT(resp.GetVec(), ElementsAre("c", "2", "d", "2")); | ||
|
|
||
| resp = | ||
| Run({"zunion", "z1", "z2", "z3", "weights", "1", "1", "2", "aggregate", "max", "withscores"}); | ||
| resp = Run({"zunion", "3", "z1", "z2", "z3", "weights", "1", "1", "2", "aggregate", "max", |
There was a problem hiding this comment.
I see that we have only checks with 3 arguments, maybe change one of the cases to check different number
1. Before that we did no support a real syntax with <numkey> argument, now we do. 2. Fix warnings. Signed-off-by: Roman Gershman <[email protected]>
romange
force-pushed
the
VariadicZunion
branch
from
9ccad8b to
f3987ed
Compare
adiholden
approved these changes
Jan 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.