fix(metrics): add master metric #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashotland <[email protected]>
Signed-off-by: ashotland <[email protected]>
Signed-off-by: ashotland <[email protected]>
the role metric is hard to work with as it generates two time serieses, for each of the role label values. Will remove the role metric once we update the production versions. Signed-off-by: ashotland <[email protected]>
adiholden
approved these changes
Aug 28, 2023
kostasrim
approved these changes
Aug 28, 2023
romange
pushed a commit
that referenced
this pull request
Aug 28, 2023
* fix: add master metric the role metric is hard to work with as it generates two time serieses, for each of the role label values. Will remove the role metric once we update the production versions. --------- Signed-off-by: ashotland <[email protected]>
kostasrim
pushed a commit
that referenced
this pull request
Aug 29, 2023
* fix: add master metric the role metric is hard to work with as it generates two time serieses, for each of the role label values. Will remove the role metric once we update the production versions. --------- Signed-off-by: ashotland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the role metric is hard to work with as it generates two time serieses, for role=master and role=replica.
Will remove the role metric once we update the production versions.
Signed-off-by: ashotland [email protected]