feat: expose tx_queue_len metric #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This metric shows how much the transaction queue of dragonfly is loaded. Also, output free text, human intended replies as verbatim. Signed-off-by: Roman Gershman <[email protected]>
adiholden
approved these changes
Dec 24, 2023
ashotland
reviewed
Dec 24, 2023
| @@ -753,9 +753,9 @@ void PrintPrometheusMetrics(const Metrics& m, StringResponse* resp) { | |||
| // Server metrics | |||
| AppendMetricHeader("version", "", MetricType::GAUGE, &resp->body()); | |||
| AppendMetricValue("version", 1, {"version"}, {GetVersion()}, &resp->body()); | |||
| AppendMetricHeader("role", "", MetricType::GAUGE, &resp->body()); | |||
| AppendMetricValue("role", 1, {"role"}, {m.is_master ? "master" : "replica"}, &resp->body()); | |||
There was a problem hiding this comment.
Ok to remove - but please cc control plane team when removing/changing existing metrics.
There was a problem hiding this comment.
sure, I thought you guys switched to the news approach 4 months after :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This metric shows how much the transaction queue of dragonfly is loaded.
Also remove the redunant
is_masterfield from metrics.Finally, removed unnecessary "role" metric from the prometheus metrics, see #1754 for the context.