chore: pass SinkReplyBuilder and Transaction explicitly. Part1 #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some of our commands we need to inject another transaction and another SinkReplyBuilder. This results into error-prone injections of temporary objects into ConnectionContext. Most commands just need Transaction and SinkReplyBuilder, so lets pass them explicitly. The final goal will be to remove Transaction and reply_builder fields from ConnectionContext. Signed-off-by: Roman Gershman <[email protected]>
dranikpg
approved these changes
Oct 20, 2024
romange
added a commit
that referenced
this pull request
Oct 20, 2024
This pr follows #3946 Signed-off-by: Roman Gershman <[email protected]>
Merged
romange
added a commit
that referenced
this pull request
Oct 21, 2024
This pr follows #3946 Signed-off-by: Roman Gershman <[email protected]>
romange
added a commit
that referenced
this pull request
Oct 23, 2024
This pr follows #3946 Signed-off-by: Roman Gershman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of our commands we need to inject another transaction and another SinkReplyBuilder. This results into error-prone injections of temporary objects into ConnectionContext. Most commands just need Transaction and SinkReplyBuilder, so lets pass them explicitly. The final goal will be to remove Transaction and reply_builder fields from ConnectionContext.