chore: pass SinkReplyBuilder and Transaction explicitly. Part2 #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
commented
Oct 20, 2024
| static void RandomKey(CmdArgList args, ConnectionContext* cntx); | ||
| static void FieldTtl(CmdArgList args, ConnectionContext* cntx); | ||
| static void FieldExpire(CmdArgList args, ConnectionContext* cntx); | ||
| static void Del(CmdArgList args, Transaction* tx, SinkReplyBuilder* builder); |
There was a problem hiding this comment.
now we are going to pass Transaction* tx, SinkReplyBuilder* builder explicitly.
romange
commented
Oct 20, 2024
| @@ -863,6 +862,99 @@ OpResult<uint64_t> OpTtl(Transaction* t, EngineShard* shard, string_view key) { | |||
| } | |||
| } | |||
|
|
|||
| ErrorReply RenameGeneric(CmdArgList args, bool destination_should_not_exist, Transaction* tx) { | |||
This pr follows #3946 Signed-off-by: Roman Gershman <[email protected]>
|
@BorysTheDev ping |
BorysTheDev
reviewed
Oct 23, 2024
| @@ -13,7 +13,6 @@ | |||
| #include "server/cluster/cluster_defs.h" | |||
| #include "server/engine_shard_set.h" | |||
| #include "server/error.h" | |||
| #include "server/generic_family.h" | |||
There was a problem hiding this comment.
I like when we remove such huge files from includes
BorysTheDev
reviewed
Oct 23, 2024
Comment on lines
+934
to
+946
| string arg_sv = absl::AsciiStrToUpper(ToSV(arg)); | ||
| if (arg_sv == "NX") { | ||
| flags |= ExpireFlags::EXPIRE_NX; | ||
| } else if (arg_sv == "XX") { | ||
| flags |= ExpireFlags::EXPIRE_XX; | ||
| } else if (arg_sv == "GT") { | ||
| flags |= ExpireFlags::EXPIRE_GT; | ||
| } else if (arg_sv == "LT") { | ||
| flags |= ExpireFlags::EXPIRE_LT; | ||
| } else { | ||
| builder->SendError(absl::StrCat("Unsupported option: ", arg_sv)); | ||
| return nullopt; | ||
| } |
There was a problem hiding this comment.
can you rewrite it with CmdArgParser
There was a problem hiding this comment.
I prefer to avoid rewriting stuff during refactoring PRs. this one is huge as it is.
BorysTheDev
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr follows #3946