Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added debug dockerfiles that support opening a terminal and Enabled LTO for rust Projects #143

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ruokun-niu
Copy link
Contributor

@ruokun-niu ruokun-niu commented Jan 23, 2025

Description

  • Added a new Dockerfile variant called Dockerfile.debug for all variants, which uses ubuntu as the final stage image.
  • The debug images can be built with the make command make docker-build-debug
  • This PR also updates the Rust profiles to use lto for release builds. By default, LTO will be used in image building processes in build-test.yml and draft-release.yml. For local debugging, when we execute a make docker-build-debug command, the Dockerfile.debug file will be used for building these images. The Dockerfiles for the Rust projects set the debug flag when running cargo install, which does not use lto.

Type of change

  • This pull request fixes a bug in Drasi and has an approved issue (issue link required).
  • This pull request adds or changes features of Drasi and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Drasi (issue link optional).

Fixes: #issue_number

@ruokun-niu ruokun-niu requested a review from a team as a code owner January 23, 2025 23:13
@ruokun-niu ruokun-niu marked this pull request as draft January 23, 2025 23:19
@ruokun-niu ruokun-niu marked this pull request as ready for review January 25, 2025 06:28
Copy link
Contributor

@amansinghoriginal amansinghoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for adding this.

…si-platform into debug-base-images

* 'debug-base-images' of https://github.com/ruokun-niu/drasi-platform:
  Transition to Native Multi-Platform Builds for Docker Images (drasi-project#161)
  Bump jinja2 from 3.1.4 to 3.1.5 in /reactions/sdk/python (drasi-project#135)
  Bump vite in /reactions/signalr/signalr-reaction/clients/vue (drasi-project#142)
  Bump nanoid in /reactions/signalr/signalr-reaction/clients/react/example (drasi-project#131)
  Bump openssl from 0.10.66 to 0.10.71 in /query-container (drasi-project#160)
  Bump golang.org/x/crypto from 0.26.0 to 0.31.0 in /cli (drasi-project#132)
  Bump nanoid in /reactions/signalr/signalr-reaction/clients/vue/example (drasi-project#130)
  Bump openssl from 0.10.68 to 0.10.71 in /sources/sdk/rust/example/proxy (drasi-project#158)
  Bump io.undertow:undertow-core from 2.3.15.Final to 2.3.17.Final in /sources/sdk/java (drasi-project#127)
  Bump esbuild from 0.16.17 to 0.25.0 in /dev-tools/vscode/drasi (drasi-project#151)
  Bump openssl from 0.10.66 to 0.10.70 in /control-planes/mgmt_api (drasi-project#148)
  Remove Fixed Dapr Version Constraint (drasi-project#147)
  Gremlin Reaction hotfix (drasi-project#149)
  EventHub Source (drasi-project#152)
  Configured the EventGrid Reaction to use different schemas (drasi-project#138)
  AWS IRSA support and Eventbridge reaction (drasi-project#140)
  init logging (drasi-project#153)
  Dotnet source sdk (drasi-project#144)
  Refactor Relational Source and add MySQL Support. (drasi-project#146)
@ruokun-niu ruokun-niu changed the title Added debug dockerfiles that support opening a terminal Added debug dockerfiles that support opening a terminal and Enabled LTO for rust Projects Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants