Skip to content

Commit

Permalink
Update _populate_job_results pagination limit to be 500 (#90)
Browse files Browse the repository at this point in the history
### Summary

Update _populate_job_results pagination limit to be 500

### Description

Change __populate_job_results()'s call of job_results() to have a limit
of 500, which is Dremio's limit. Part 1 of the fix, with part 2 being
implementing pagination.

### Test Results

Ran all of the tests using software, with them all passing apart from a
known failure in tests/functional/adapter/grants/test_model_grants.py.

### Changelog

-   [x] Added a summary of what this PR accomplishes to CHANGELOG.md

### Related Issue

#61
  • Loading branch information
ArgusLi authored Nov 24, 2022
1 parent 71d8a2c commit f8b6d09
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

- Override dbt-core `default__type_string()` macro to use Dremio Supported VARCHAR instead of the default string. ([#80](https://github.com/dremio/dbt-dremio/pull/80))

- Change \_populate_job_results() to have limit of 500 (Dremio's limit).

## Under the Hood

## Dependency
2 changes: 1 addition & 1 deletion dbt/adapters/dremio/api/cursor.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def _populate_rowcount(self):
def _populate_job_results(self):
if self._job_results == None:
self._job_results = job_results(
self._parameters, self._job_id, offset=0, limit=100, ssl_verify=True
self._parameters, self._job_id, offset=0, limit=500, ssl_verify=True
)

def _populate_results_table(self):
Expand Down

0 comments on commit f8b6d09

Please sign in to comment.