Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _populate_job_results pagination limit to be 500 #90

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Nov 24, 2022

Summary

Update _populate_job_results pagination limit to be 500

Description

Change __populate_job_results()'s call of job_results() to have a limit of 500, which is Dremio's limit. Part 1 of the fix, with part 2 being implementing pagination.

Test Results

Ran all of the tests using software, with them all passing apart from a known failure in tests/functional/adapter/grants/test_model_grants.py.

Changelog

  • Added a summary of what this PR accomplishes to CHANGELOG.md

Related Issue

#61

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ArgusLi ArgusLi linked an issue Nov 24, 2022 that may be closed by this pull request
@ArgusLi ArgusLi requested a review from ravjotbrar November 24, 2022 22:04
@ArgusLi ArgusLi merged commit f8b6d09 into main Nov 24, 2022
@ArgusLi ArgusLi deleted the 61-raw-reflection-limits-display-columns-to-100-pt-1 branch November 24, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Raw reflection limits display columns to 100
2 participants