Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _populate_job_results pagination limit to be 500 #90

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Update _populate_job_results pagination limit to be 500 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

- Override dbt-core `default__type_string()` macro to use Dremio Supported VARCHAR instead of the default string. ([#80](https://github.com/dremio/dbt-dremio/pull/80))

- Change \_populate_job_results() to have limit of 500 (Dremio's limit).

## Under the Hood

## Dependency
2 changes: 1 addition & 1 deletion dbt/adapters/dremio/api/cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def _populate_rowcount(self):
def _populate_job_results(self):
if self._job_results == None:
self._job_results = job_results(
self._parameters, self._job_id, offset=0, limit=100, ssl_verify=True
self._parameters, self._job_id, offset=0, limit=500, ssl_verify=True
)

def _populate_results_table(self):
Expand Down