-
Notifications
You must be signed in to change notification settings - Fork 147
Conversation
Currently, I'm working on the training part adjustment of |
30dc1a5
to
d7a95e9
Compare
Restarted the travis build since the error occurred before even reaching the tests. |
pull_size (int): maximum amount of batches allowed to be stored in RAM. | ||
""" | ||
|
||
@abc.abstractmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does abstractmethod
do in this case? Python docs say,
Using this decorator requires that the class’s metaclass is ABCMeta or is derived from it.
Also, why not use a new style class, i.e., class ClassificationModel(object):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, thanks :)
d7a95e9
to
73226c2
Compare
a7bd393
to
dbf800e
Compare
Okh, this line along with removal this one makes me suffer for a while and force to code and tests updates. Unfortunately, at the moment of PR #272 I did not have the opportunity to provide a review, now to be clear: |
dbf800e
to
a4f5846
Compare
@vessemer Can you rework your previous comment into the code itself? Remarks here are really really useful (!) but it won't be clear to anyone following the codebase later, you see... |
@lamby, good point, done :) |
d921425
to
f5e1619
Compare
f5e1619
to
ab71933
Compare
Thanks! |
# predicted = trained_model.predict(dicom_paths[0], nodule_locations, model_path) | ||
# assert predicted | ||
# assert 0 <= predicted[0]['p_concerning'] <= 1 | ||
# | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment out these tests? Anything else needed to keep them passing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at all, just forget to uncomment them, done here
Pipeline to train and predict by the model was provided along with an interface for
classification_model
.Reference to official issue
#131
Metrics:
Model' CPM score was described in PR #292:
CPM over 10-Fold cross validation:
CLA