Allow steps to work without input #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
commented
Jul 19, 2017
| @@ -56,7 +56,12 @@ def call(input) | |||
| end | |||
|
|
|||
| def arity | |||
| operation.is_a?(Proc) ? operation.arity : operation.method(:call).arity | |||
| case operation | |||
| when Proc, Method | |||
There was a problem hiding this comment.
I notice that the arity function was returning invalid data since we added the functionality of using methods as steps
GustavoCaso
commented
Jul 19, 2017
| @@ -4,6 +4,16 @@ module Dry | |||
| module Transaction | |||
| class StepAdapters | |||
| extend Dry::Container::Mixin | |||
|
|
|||
| module Resolver | |||
There was a problem hiding this comment.
I placed here this code iniside the Resolver module because it was been repeated across all steps. If we do not like this solution I have other options in my mind.
Instead of instantiating the step when registering, we could simply register the class,
later in the call in the step class, we could
def call(input)
args = [input] + Array(call_args)
result = step_adapter.new(self, *args).call
......
endThis way we could make all the steps inherite from maybe some StepBase class that have this resolve method 😄
GustavoCaso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #59
@timriley I decided to give a try to this one. I came up with this solution I wanted to share it so we can discuss it, and see if it's fit with in the library