Support calling steps with no input arguments (take 2) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
force-pushed
the
allow-steps-without-input-arguments-2
branch
from
9a19ed5 to
a740a72
Compare
|
@GustavoCaso just adjusted this so it's rebased on top of your changes. If we're happy with this I'll squish the commits and give them a nicer message :) |
|
@timriley I'm happy with the changes. It makes more sense to by in the step that in a separate |
GustavoCaso
approved these changes
Jul 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some steps in a transaction may not accept any input. Make it easy for step adapters to support calling these operations by adding a
Step#call_operationmethod. This only calls the operation with args if it accepts any.@GustavoCaso I tried this as another take on your work in #68. I didn't want to make each step adapter class have to include that
Resolvermodule to get this support, so I thought it might be worth adding it on theStepclass directly. What do you think?