Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Checker that notify every VATZ is up and running properly. #166

Closed
1 of 3 tasks
xellos00 opened this issue Jul 6, 2022 · 4 comments · Fixed by #190
Closed
1 of 3 tasks

Health Checker that notify every VATZ is up and running properly. #166

xellos00 opened this issue Jul 6, 2022 · 4 comments · Fixed by #190
Assignees
Labels
area:svc Anything related to Vatz Service. type:feature-development Any development regarding Vatz service/plugin, etc. Vatz Project Name

Comments

@xellos00
Copy link
Member

xellos00 commented Jul 6, 2022

Checklist

  • New Feature for the Service/Plugin (Vatz)
  • Enhancement (Vatz)
  • others(etc. e.g, documentation, project policy management)

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. such as Ex. I'm always frustrated

I'm always frustrated with currently there's no checker or notification VATZ is running to discord.

Describe the solution you'd like| Ex

A clear and concise description of what you want to happen

Send a notification to protocol channel to notify to Validator team

  • whether it is up and running

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you have considered.

Additional context or comment

Add any other context or screenshots about the feature request here.

the health check was similar to the alert reminder. Because Health check means vatz can send the INFO alert again. So we tried to develop the health check when the alert reminder developed.

@xellos00 xellos00 added Vatz Project Name type:feature-development Any development regarding Vatz service/plugin, etc. area:svc Anything related to Vatz Service. type:discussion Issue that has to go over discussion. labels Jul 6, 2022
@xellos00
Copy link
Member Author

xellos00 commented Jul 6, 2022

기존의 Node-manager 한국시간 10:03 reminder가 옵니다.
Requirements

  1. crontab 과 같은 schedule이 가능하게 해주세요.
  2. 예를 들어 go-cron과 같은 package가 있습니다. 참고해 주세요.

@heejin-github, @kim201212

There's no function in VATZ as same as above.

  1. Update label to create alive
  2. development

@kim201212 kim201212 removed the type:discussion Issue that has to go over discussion. label Jul 6, 2022
@kim201212
Copy link
Member

@heejin-github and I decided to develop a function to send metric information using promethus first and make a health checker.

Prometheus issue : #169

@xellos00
Copy link
Member Author

xellos00 commented Jul 9, 2022

@heejin-github and I decided to develop a function to send metric information using promethus first and make a health checker.

Prometheus issue : #169

@heejin-github
@kim201212

Let's separate issue two things, I do not want to dup issue.
As I mentioned in #169 (comment)

@heejin-github
Copy link
Member

@heejin-github and I decided to develop a function to send metric information using promethus first and make a health checker.
Prometheus issue : #169

@heejin-github @kim201212

Let's separate issue two things, I do not want to dup issue. As I mentioned in #169 (comment)

@xellos00
As I mentioned in #169 (comment), it's already separated.
We'll NOT handle any prometheus related issues or discussion in this issue.

@kim201212 kim201212 mentioned this issue Jul 20, 2022
4 tasks
@xellos00 xellos00 linked a pull request Jul 20, 2022 that will close this issue
4 tasks
xellos00 pushed a commit that referenced this issue Jul 22, 2022
- import grpc/health package
- set serving status for response from health check request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:svc Anything related to Vatz Service. type:feature-development Any development regarding Vatz service/plugin, etc. Vatz Project Name
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants