Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus integration #169

Closed
1 of 3 tasks
heejin-github opened this issue Jul 8, 2022 · 9 comments
Closed
1 of 3 tasks

Prometheus integration #169

heejin-github opened this issue Jul 8, 2022 · 9 comments
Assignees
Labels
area:svc Anything related to Vatz Service. good_first_issue Good for newcomers type:feature-development Any development regarding Vatz service/plugin, etc. Vatz Project Name

Comments

@heejin-github
Copy link
Member

heejin-github commented Jul 8, 2022

Checklist

  • New Feature for the Service/Plugin (Vatz)
  • Enhancement (Vatz)
  • others(etc. e.g, documentation, project policy management)

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. such as Ex. I'm always frustrated

There's no method to monitor vatz itself. we need monitoring system for vatz.
Let's start to integrate prometheus from this issue, and we'll handle monitoring for vatz liveness in this issue first.

Describe the solution you'd like| Ex

A clear and concise description of what you want to happen

serve prometheus metrics of liveness for vatz monitoring.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you have considered.

#166 vatz health checker will monitor vatz together.

Additional context or comment

Add any other context or screenshots about the feature request here.

@heejin-github heejin-github added Vatz Project Name type:feature-development Any development regarding Vatz service/plugin, etc. labels Jul 8, 2022
@xellos00
Copy link
Member

xellos00 commented Jul 8, 2022

@heejin-github
@kim201212

@Choi-Jinhong
Are you going to pass this issue to @heejin-github @kim201212
for monitoring and notification?

@kim201212
Copy link
Member

kim201212 commented Jul 9, 2022

@heejin-github @kim201212

@Choi-Jinhong Are you going to pass this issue to @heejin-github @kim201212 for monitoring and notification?

@xellos00
This issue and the Health check issue (#166) are different. It is already detached.
@heejin-github and I thought the health check was similar to the alert reminder. Because Health check means vatz can send the INFO alert again. So we tried to develop the health check when @Choi-Jinhong developed the alert reminder.
We thought the Health check is a future requirement.
So we decided to develop the prometheus that we needed right away.
Please let me know if you have any ideas.

@xellos00
Copy link
Member

xellos00 commented Jul 9, 2022

@heejin-github @kim201212

@Choi-Jinhong Are you going to pass this issue to @heejin-github @kim201212 for monitoring and notification?

@xellos00 This issue and the Health check issue (#166) are different. It is already detached. @heejin-github and I thought the health check was similar to the alert reminder. Because Health check means vatz can send the INFO alert again. So we tried to develop the health check when @Choi-Jinhong developed the alert reminder. We thought the Health check is a future requirement. So we decided to develop the prometheus that we needed right away. Please let me know if you have any ideas.

@kim201212
Please, update this issue's description.
I guess current description on this issue is wrong info If it is detached with #166.

@kim201212
Copy link
Member

@heejin-github @kim201212

@Choi-Jinhong Are you going to pass this issue to @heejin-github @kim201212 for monitoring and notification?

@xellos00 This issue and the Health check issue (#166) are different. It is already detached. @heejin-github and I thought the health check was similar to the alert reminder. Because Health check means vatz can send the INFO alert again. So we tried to develop the health check when @Choi-Jinhong developed the alert reminder. We thought the Health check is a future requirement. So we decided to develop the prometheus that we needed right away. Please let me know if you have any ideas.

@kim201212 Please, update this issue's description. I guess current description on this issue is wrong info If it is detached with #166.

I said "detached" wrong.
I mean, developing two functions into two different issues.
The two functions are related to each other.

@xellos00
Copy link
Member

xellos00 commented Jul 9, 2022

@heejin-github @kim201212

@Choi-Jinhong Are you going to pass this issue to @heejin-github @kim201212 for monitoring and notification?

@xellos00 This issue and the Health check issue (#166) are different. It is already detached. @heejin-github and I thought the health check was similar to the alert reminder. Because Health check means vatz can send the INFO alert again. So we tried to develop the health check when @Choi-Jinhong developed the alert reminder. We thought the Health check is a future requirement. So we decided to develop the prometheus that we needed right away. Please let me know if you have any ideas.

@kim201212 Please, update this issue's description. I guess current description on this issue is wrong info If it is detached with #166.

I said "detached" wrong. I mean, developing two functions into two different issues. The two functions are related to each other.

@kim201212
Let's make it clear.

  1. Prometheus integration is a big chunk and therefore it has to be divided into sub-issue. Prometheus integration represents VATZ monitoring overall purpose and furthermore for metric data storing.

  2. This issue should be separated from Health Checker that notify every VATZ is up and running properly.  #166 because Health Checker that notify every VATZ is up and running properly.  #166 was discussion for "how we get notification message that VATZ is up and running".
    Let's separate it.

Issue's title Prometheus integration is way too vague.
Can you or let @heejin-github update description on this issue to mention for followings
Lets create sub-issue to have full functional Prometheus integration.

  • Specify each To do lists for Prometheus integration.
    • Set Prometheus on K8s
    • How to modify or update VATZ config for Prometheus
    • How does monitoring module has to be desgiened
    • Sending metrics data to Prometheus that integrated with notification module
      • which VATZ metric will be delivered at first (suggest aliveness first)
      • How to test it.

Let me know if anyone need explanation for this.

@xellos00 xellos00 added the area:svc Anything related to Vatz Service. label Jul 9, 2022
@heejin-github
Copy link
Member Author

@heejin-github @kim201212

@Choi-Jinhong Are you going to pass this issue to @heejin-github @kim201212 for monitoring and notification?

@xellos00 This issue and the Health check issue (#166) are different. It is already detached. @heejin-github and I thought the health check was similar to the alert reminder. Because Health check means vatz can send the INFO alert again. So we tried to develop the health check when @Choi-Jinhong developed the alert reminder. We thought the Health check is a future requirement. So we decided to develop the prometheus that we needed right away. Please let me know if you have any ideas.

@kim201212 Please, update this issue's description. I guess current description on this issue is wrong info If it is detached with #166.

I said "detached" wrong. I mean, developing two functions into two different issues. The two functions are related to each other.

@kim201212 Let's make it clear.

  1. Prometheus integration is a big chunk and therefore it has to be divided into sub-issue. Prometheus integration represents VATZ monitoring overall purpose and furthermore for metric data storing.
  2. This issue should be separated from Health Checker that notify every VATZ is up and running properly.  #166 because Health Checker that notify every VATZ is up and running properly.  #166 was discussion for "how we get notification message that VATZ is up and running".
    Let's separate it.

Issue's title Prometheus integration is way too vague. Can you or let @heejin-github update description on this issue to mention for followings Lets create sub-issue to have full functional Prometheus integration.

  • Specify each To do lists for Prometheus integration.

    • Set Prometheus on K8s

    • How to modify or update VATZ config for Prometheus

    • How does monitoring module has to be desgiened

    • Sending metrics data to Prometheus that integrated with notification module

      • which VATZ metric will be delivered at first (suggest aliveness first)
      • How to test it.

Let me know if anyone need explanation for this.

@xellos00

  1. Divide into sub-issue.
  • Good idea. Let's make sub-issue for integrating prometheus into vatz.
    actually, I just create this issue as a starting point of prometheus integration. I'll update description and title for this issue more clear as you requested, and Please create a new issue for prometheus integration as you thought or designed. then, I'll link it as a parent issue of this.
  1. Nobody wanted to develop prometheus and vatz health checker in one issue.

@heejin-github heejin-github changed the title Prometheus integration Prometheus integration for checking liveness Jul 11, 2022
@heejin-github
Copy link
Member Author

Hold this issue until vatz refactoring done.

@xellos00
Copy link
Member

Hold this issue until vatz refactoring done.

I create this issue as first good issue

@xellos00 xellos00 added the good_first_issue Good for newcomers label Jul 14, 2022
@xellos00 xellos00 changed the title Prometheus integration for checking liveness Prometheus integration Jul 14, 2022
@xellos00
Copy link
Member

xellos00 commented Mar 1, 2023

Prometheus integration is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:svc Anything related to Vatz Service. good_first_issue Good for newcomers type:feature-development Any development regarding Vatz service/plugin, etc. Vatz Project Name
Projects
None yet
Development

No branches or pull requests

3 participants