Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect arguments in particle predictor #660

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

sdhiscocks
Copy link
Member

control_input doesn't match base class, and isn't used.

@sdhiscocks sdhiscocks added the bug label Jun 20, 2022
@sdhiscocks sdhiscocks requested a review from a team as a code owner June 20, 2022 10:41
@sdhiscocks sdhiscocks requested review from jswright-dstl and nperree-dstl and removed request for a team June 20, 2022 10:41
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #660 (39e0263) into main (aaa895b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         168      168           
  Lines        8429     8429           
  Branches     1630     1630           
=======================================
  Hits         7960     7960           
  Misses        348      348           
  Partials      121      121           
Flag Coverage Δ
integration 67.70% <100.00%> (ø)
unittests 92.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stonesoup/predictor/particle.py 88.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa895b...39e0263. Read the comment docs.

@sdhiscocks sdhiscocks merged commit c4cd36c into main Jun 20, 2022
@sdhiscocks sdhiscocks deleted the particle_pred_fix branch June 20, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants