Add caching of mean and covar on ParticleState #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has significant performance improvements, for the trade off of limiting editing to state vector and weight of the ParticleState. However, they can still be replaced with another array, clearing the cache. Minor issue is use of standard library `functools.cached_property` is only available from Python 3.8, so to maintain compatibility with Python 3.7, `cached_property` code snippet is also included.
sdhiscocks
requested review from
nperree-dstl and
jwragg-dstl
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 94.60% 94.63% +0.02%
==========================================
Files 170 171 +1
Lines 8548 8575 +27
Branches 1654 1659 +5
==========================================
+ Hits 8087 8115 +28
+ Misses 342 339 -3
- Partials 119 121 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jwragg-dstl
approved these changes
Aug 5, 2022
nperree-dstl
approved these changes
Aug 8, 2022
sdhiscocks
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has significant performance improvements, for the trade off of limiting editing to state vector and weight of the ParticleState. However, they can still be replaced with another array, clearing the cache.
Minor issue is use of standard library
functools.cached_propertyis only available from Python 3.8, so to maintain compatibility with Python 3.7,cached_propertycode snippet is also included.