Skip to content

Commit

Permalink
Make keep_open: true the default setting for dbt-duckdb going forward (
Browse files Browse the repository at this point in the history
…#502)

* Make keep_open: true the default setting for dbt-duckdb going forward

* Curious about some test updates here

* Okay that does not seem keep_open-related, good
  • Loading branch information
jwills authored Jan 21, 2025
1 parent 18ebdc6 commit 2634221
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions dbt/adapters/duckdb/credentials.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,7 @@ class DuckDBCredentials(Credentials):
disable_transactions: bool = False

# Whether to keep the DuckDB connection open between invocations of dbt
# (we do this automatically for in-memory or MD connections, but not for
# local DuckDB files, but this is a way to override that behavior)
keep_open: bool = False
keep_open: bool = True

# A list of paths to Python modules that should be loaded into the
# running Python environment when dbt is invoked; this is useful for
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/adapter/test_community_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
run_dbt,
)

@pytest.mark.skip_profile("nightly", reason="Cannot install community extensions for nightly release")
@pytest.mark.skip_profile("buenavista", "nightly", reason="Cannot install community extensions for nightly release")
class BaseCommunityExtensions:

@pytest.fixture(scope="class")
Expand Down

0 comments on commit 2634221

Please sign in to comment.