Make keep_open: true the default setting for dbt-duckdb going forward #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guenp that plugins test is failing for delta tables for seemingly unrelated reasons (i tested it w/ and w/o the keep_open settings in place) |
guenp
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of DuckDB (>= 1.13) seem to perform better/more reliably when we leave the connection to the DuckDB file open for the entire DuckDB run vs. the old behavior of having different threads open/close the file in rapid succession, so moving to a model where we generally take ownership of the DuckDB file for the length of any dbt run unless explictly told not to in the profiles.yml.