Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate .wait_id from future to SampleSet #1393

Conversation

randomir
Copy link
Member

Close #1392.

@randomir randomir force-pushed the feature/extend-sampleset-from-future-with-wait/issue-1392 branch from c282086 to 8bf636f Compare October 11, 2024 13:58
@randomir randomir marked this pull request as ready for review October 11, 2024 13:58
@randomir randomir requested a review from arcondello October 11, 2024 13:58
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (e965bb7) to head (8bf636f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          98       98           
  Lines       10477    10484    +7     
=======================================
+ Hits         9940     9947    +7     
  Misses        537      537           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arcondello arcondello added the enhancement New feature or request label Oct 11, 2024
@randomir randomir merged commit 3de9c5f into dwavesystems:main Oct 11, 2024
41 checks passed
@randomir randomir deleted the feature/extend-sampleset-from-future-with-wait/issue-1392 branch October 11, 2024 16:24
randomir added a commit to randomir/dwave-system that referenced this pull request Oct 25, 2024
randomir added a commit to randomir/dwave-system that referenced this pull request Oct 25, 2024
pau557 pushed a commit to pau557/dwave-system that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate wait_id from future to SampleSet on construction from_future
2 participants