Fix inconsistent sampleset interface across hybrid samplers #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BQM/CQM samplers return a sampleset with `wait_id()`, but CQM doesn't.
arcondello
approved these changes
Oct 25, 2024
The fix is implemented in dwavesystems/dimod#1393, and supported by dwavesystems/dwave-cloud-client#674.
randomir
force-pushed
the
fix-inconsistent-sampleset-across-hybrid-samplers
branch
from
a04d1d1 to
e2e64b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 20 20
Lines 1582 1582
=======================================
Hits 1407 1407
Misses 175 175 ☔ View full report in Codecov by Sentry. |
randomir
deleted the
fix-inconsistent-sampleset-across-hybrid-samplers
branch
randomir
added a commit
to randomir/dwave-system
that referenced
this pull request
Nov 29, 2024
Missed a case in dwavesystems#544.
randomir
added a commit
that referenced
this pull request
Nov 29, 2024
…s-when-api-unavailable Skip live hybrid tests missed in #544
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure sampleset returned always has a working
wait_id()method.The fix was actually implemented in dwavesystems/dimod#1393 (released in dimod 0.12.18), and supported with dwavesystems/dwave-cloud-client#674 in cloud-client.
On the dwave-system level, it's enough to require the latest dimod.
Fix #540.