SQL Generation #31

jrans · 2016-09-23T15:35:32Z

THIS PR

Main issue: #11

In this PR we create handlers for db interactions:

create table
- validates config object is good Validator for config | create table #39 before creating table with columns of correct type
insert
- takes object of the form { fields }
update
- takes object of the form { fields, where }
delete
- takes object of the form { where }
select
- takes object of the form { select, where }

Check update to README.md to see necessary steps to run db tests. #34

…the DB outside the request lifecycle: issue #33

+ mapper that takes name, type and extra config options and produces sql string to create a column for setting up table + works for both pqsl and sql

…, because too complicated. Issue #11, #26

…able with the correct fields and types; issue #11

…numbers of columns.

…s). Write and test an update method; issue #11

+ use joi to validate the config for creating a table Related: #39

…ql-generation

…schema object

…ql-generation

…igure the query

…ql-generation

nelsonic · 2016-09-26T22:25:48Z

@Looks promising. assign when ready. 👍

Conflicts: lib/index.js test/index.test.js

…ql-generation

eliasmalik · 2016-09-28T12:44:32Z

@nelsonic the build is failing b/c there's no travis YAML (it's on @SimonLab 's PR) so travis is trying to run the node app in ruby. If you run the tests manually, they all pass. There are linter errors, but we want to sort those out in a separate PR (see #46). So I think this PR is OK to review! 👍

eliasmalik · 2016-09-28T17:44:03Z

Have now:

merged with master
sorted conflicts
fixed linter errors (@Shouston3)
added postgres to travis config to fix failing tests

@nelsonic please have a look!

nelsonic · 2016-09-29T07:54:04Z

WoW! 830 Lines ... better get to it! 👀

nelsonic · 2016-09-29T08:23:34Z

lib/config_validator.js

+  .unknown()
+;
+var configSchema = Joi.object().keys({
+  table_name: Joi.string().regex(dbNameRegEx).required(), // eslint-disable-line


purely out of curiosity, why do these lines need to be disabled for eslint?

@nelsonic because there's a rule that says max of 2 chained method calls per line. Bit annoying in this case.

Ah, lame. although for git diff purposes splitting over more lines is more review-able... (fine for now)

nelsonic · 2016-09-29T09:18:00Z

lib/db.js

+  configValidator(config);
+
+  return client.query(sqlGen.init(config), cb);
+} };


does this pass the linter?
(thought it would require the init to be on a new line and these closing brackets too... if not. fair enough...)

nelsonic · 2016-09-29T09:30:40Z

lib/utils.js

@@ -0,0 +1,18 @@
+'use strict';


does goodparts enforce having the 'use strict'; at the top of our files...?

yes, we have added this rule in the goodparts config:
dwyl/goodparts#128
I'm not sure if we should use it, maybe we can reopen this issue on goodparts

Thanks @SimonLab. yes, I agree we need to understand the benefits of the 'use strict'; directive.

nelsonic · 2016-09-29T09:31:49Z

lib/utils.js

@@ -0,0 +1,18 @@
+'use strict';
+
+exports.values = function (obj, keys) {


are these utils independently unit-tested somewhere?

there are unit tests here for everyone except except ! @eliasCodes i'll write it?

nelsonic · 2016-09-29T09:43:13Z

Code looks good. merging. 👍

eliasmalik and others added 24 commits September 23, 2016 16:34

Add skeleton of plugin and example hapi server. Issue #30

0f46477

Add env2 for DB config: issue #34

70b3e00

add hapi-postgres-connection as a plugin to example server #33

80522d4

use pg instead of hapi-postgres-connection because we need access to …

e834b0b

…the DB outside the request lifecycle: issue #33

update sql queries in plugin setup

228ebc4

add first pass of sql data map

b3c23d1

[WIP] add module file for generating sql, and corresponding test file

c435d44

➕ mapper for creating sql columns

5821399

+ mapper that takes name, type and extra config options and produces sql string to create a column for setting up table + works for both pqsl and sql

change field-names to align with Joi API; moved away from JSON schema…

e059f22

…, because too complicated. Issue #11, #26

write and test init method of sqlGen module to make query to create t…

da01305

…able with the correct fields and types; issue #11

write and test function to generate update SQL queries for arbitrary …

3cb409a

…numbers of columns.

rename previous 'update' method to 'insert' (since that's what it doe…

3110924

…s). Write and test an update method; issue #11

delete dead line

9c5fb29

➕ config validator

a45b93f

+ use joi to validate the config for creating a table Related: #39

Merge branch 'sql-generation' of https://github.com/dwyl/abase into s…

31ce282

…ql-generation

change module inputs to inject table_name directly instead of entire …

431e786

…schema object

write and test sql generator for SELECT queries

9ee0209

write and test SQL generator function for DELETE queries

5cd2536

Merge branch 'sql-generation' of https://github.com/dwyl/abase into s…

e8dd68a

…ql-generation

migrate to new interface, expecting an options object instead to conf…

ad3139b

…igure the query

add where clause to select method

5b08cf6

🐛 allow extra keys on field config #39

aff1574

🎨 🔥 refactor out test fixture

0f670c8

Merge branch 'sql-generation' of https://github.com/dwyl/abase into s…

35f96ad

…ql-generation

jrans and others added 5 commits September 27, 2016 09:34

➕ Expose database methods #11

3296cab

Fix tests

743656a

Merge branch 'master' into sql-generation

f6a61b5

Conflicts: lib/index.js test/index.test.js

📝 Update readme on test config

b2d42f6

Merge branch 'sql-generation' of https://github.com/dwyl/abase into s…

b7c8d8d

…ql-generation

iteles assigned eliasmalik Sep 28, 2016

samhstn added 2 commits September 28, 2016 13:24

fixing merge conflicts

d4f8fea

fixing linting errors

a57d5d3

eliasmalik assigned nelsonic and unassigned eliasmalik Sep 28, 2016

jrans assigned samhstn Sep 28, 2016

eliasmalik and others added 10 commits September 28, 2016 15:21

change eslint back to goodparts

cd802d4

auto fix linter errors

d9eefed

fix linter errors

ae66662

add config.env to gitignore

cc62b23

Merge branch 'master' into goodparts

ea3daca

fixing linting

9b05448

bring branch coverage back up to 100%

19889da

add istanbul YAML

2148f3f

add postgres to travis to fix failing tests

273bc9c

create travis test database before script execution

7389e59

🎨 Change ordering of require

281c883

nelsonic reviewed Sep 29, 2016

View reviewed changes

eliasmalik mentioned this pull request Sep 29, 2016

Integration: SQL generation #56

Closed

nelsonic reviewed Sep 29, 2016

View reviewed changes

jrans mentioned this pull request Sep 29, 2016

Hashing Data #58

Closed

nelsonic reviewed Sep 29, 2016

View reviewed changes

nelsonic merged commit 375a801 into master Sep 29, 2016

nelsonic deleted the sql-generation branch September 29, 2016 09:43

samhstn mentioned this pull request Sep 30, 2016

Connecting to PG database #33

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SQL Generation #31

SQL Generation #31

jrans commented Sep 23, 2016 •

edited

Loading

nelsonic commented Sep 26, 2016

eliasmalik commented Sep 28, 2016

eliasmalik commented Sep 28, 2016 •

edited

Loading

nelsonic commented Sep 29, 2016

nelsonic Sep 29, 2016

eliasmalik Sep 29, 2016 •

edited

Loading

nelsonic Sep 29, 2016

nelsonic Sep 29, 2016

nelsonic Sep 29, 2016

SimonLab Sep 29, 2016

nelsonic Sep 29, 2016

nelsonic Sep 29, 2016

jrans Sep 29, 2016 •

edited

Loading

nelsonic commented Sep 29, 2016

		@@ -0,0 +1,18 @@
		'use strict';

		exports.values = function (obj, keys) {

SQL Generation #31

SQL Generation #31

Conversation

jrans commented Sep 23, 2016 • edited Loading

THIS PR

nelsonic commented Sep 26, 2016

eliasmalik commented Sep 28, 2016

eliasmalik commented Sep 28, 2016 • edited Loading

nelsonic commented Sep 29, 2016

nelsonic Sep 29, 2016

Choose a reason for hiding this comment

eliasmalik Sep 29, 2016 • edited Loading

Choose a reason for hiding this comment

nelsonic Sep 29, 2016

Choose a reason for hiding this comment

nelsonic Sep 29, 2016

Choose a reason for hiding this comment

nelsonic Sep 29, 2016

Choose a reason for hiding this comment

SimonLab Sep 29, 2016

Choose a reason for hiding this comment

nelsonic Sep 29, 2016

Choose a reason for hiding this comment

nelsonic Sep 29, 2016

Choose a reason for hiding this comment

jrans Sep 29, 2016 • edited Loading

Choose a reason for hiding this comment

nelsonic commented Sep 29, 2016

jrans commented Sep 23, 2016 •

edited

Loading

eliasmalik commented Sep 28, 2016 •

edited

Loading

eliasmalik Sep 29, 2016 •

edited

Loading

jrans Sep 29, 2016 •

edited

Loading