Add goodparts to project #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin to get it working w/ atom otherwise
|
To be merged after #41 |
Current coverage is 100% (diff: 100%)@@ master #46 diff @@
===================================
Files 4 4
Lines 35 36 +1
Methods 8 8
Messages 0 0
Branches 5 5
===================================
+ Hits 35 36 +1
Misses 0 0
Partials 0 0
|
Merged
jrans
requested changes
Sep 28, 2016
There was a problem hiding this comment.
Great work @eliasCodes with the rule just one minor change on he package.json
| "lint": "node_modules/.bin/eslint .", | ||
| "lint:fix": "node_modules/.bin/eslint . --fix", | ||
| "lint": "node_modules/.bin/goodparts .", | ||
| "lint:init": "ln -sf node_modules/goodparts/.eslintrc.js ./.eslintrc.js", |
There was a problem hiding this comment.
See how lin and lint fix are handy scripts to add but feel like lint:init should be done on the postinstall of the goodparts module. Strange that those goodparts goodtime guys would expect you to add this script to your package.json before installing to get the linting kicked off..
| "coverage": "node_modules/.bin/istanbul cover node_modules/.bin/tape ./test/*.test.js", | ||
| "codecov": "node_modules/.bin/codecov --token=${CODECOV_TOKEN}" | ||
| "codecov": "node_modules/.bin/codecov --token=${CODECOV_TOKEN}", | ||
| "postinstall": "npm run lint:init" |
| @@ -3,3 +3,4 @@ node_modules | |||
| coverage | |||
| npm-debug.log | |||
| .eslintrc* | |||
| config.env | |||
There was a problem hiding this comment.
strictly shouldn't be in this PR but will let it slide just this once ;)
Also change name back to abase and to version 1.0.0
jrans
approved these changes
Sep 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
lint:xxxscripts to use goodparts binary instead of eslintlint:initscript to symlink the goodparts.eslintrc.jsinto rooteslintpackage in the atomlinter-eslintpackage settings