Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Environment Variables for Google OAuth Client Credentials #13

Closed
nelsonic opened this issue Nov 27, 2019 · 2 comments
Closed

Use Environment Variables for Google OAuth Client Credentials #13

nelsonic opened this issue Nov 27, 2019 · 2 comments
Labels
discuss question Further information is requested technical

Comments

@nelsonic
Copy link
Member

At present, the instructions in the README.md suggest putting the google_client_id in the config.exs file:

image

Could we store both the GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET in the environment (or in an .env file) and load it at run-time instead of hard-coding them in the config.exs file?
@nelsonic nelsonic added question Further information is requested discuss technical labels Nov 27, 2019
@nelsonic
Copy link
Member Author

nelsonic commented Nov 27, 2019 •
edited
Loading

nelsonic added a commit that referenced this issue Nov 27, 2019
@nelsonic
show sample .env with GOOGLE_CLIENT_etc variables for #10 #13
8cff686
nelsonic added a commit that referenced this issue Nov 28, 2019
@nelsonic
add link to github.com/dwyl/learn-environment-variables for #10 #13
9ca2797
@nelsonic
Copy link
Member Author

nelsonic commented Dec 5, 2019

PR #11 adds detailed instructions for environment variables for Google API keys. ✅

@nelsonic nelsonic closed this as completed Dec 5, 2019
@nelsonic nelsonic mentioned this issue Feb 17, 2020
Merged
nelsonic added a commit that referenced this issue Feb 17, 2020
@nelsonic
remove Application.put_env(:elixir_auth_google, :google_client_id ...…
ebc0aa7 
… use env vars #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss question Further information is requested technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic