Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add state in oauth url #34

Merged
merged 6 commits into from
Feb 17, 2020
Merged

add state in oauth url #34

merged 6 commits into from
Feb 17, 2020

Conversation

SimonLab
Copy link
Member

ref: #33

@codecov
Copy link

codecov bot commented Feb 17, 2020 •
edited
Loading

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     16    +1     
=====================================
+ Hits           15     16    +1
Impacted Files Coverage Δ
lib/elixir_auth_google.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7104868...5d8bd5f. Read the comment docs.

@SimonLab SimonLab requested a review from nelsonic February 17, 2020 13:56
nelsonic
nelsonic reviewed Feb 17, 2020
View reviewed changes
@SimonLab @nelsonic
Update mix.exs
10866dc 
Co-Authored-By: Nelson <[email protected]>
nelsonic
nelsonic approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. let's ship this! 👍

@nelsonic nelsonic merged commit 373a7be into master Feb 17, 2020
@nelsonic nelsonic deleted the state-url branch February 17, 2020 16:35
nelsonic added a commit that referenced this pull request Feb 17, 2020
@nelsonic
bump recommended version in README.md to 1.1.0 for #34
6475166
@nelsonic
Copy link
Member

Package published to https://hex.pm/packages/elixir_auth_google/1.1.0 🚀

@SimonLab SimonLab mentioned this pull request Feb 17, 2020
Closed
13 tasks
@SimonLab SimonLab mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic