Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As part of improving code-readability can we also conform to ESLint (e.g: goodparts) ? #211

Closed
nelsonic opened this issue Nov 19, 2016 · 0 comments
Closed

As part of improving code-readability can we also conform to ESLint (e.g: goodparts) ? #211

nelsonic opened this issue Nov 19, 2016 · 0 comments
Labels
enhancement help wanted question

Comments

@nelsonic
Copy link
Member

nelsonic commented Nov 19, 2016 •
edited
Loading

As part of improving our in-line JSDocs #203 can we also Lint the code to ensure that it's consistent? e.g: using "Javascript The Good Parts" ?

jwt2-goodparts-linting
jwt2-goodparts-linting-total

https://en.wikipedia.org/wiki/Ministries_of_Nineteen_Eighty-Four#Room_101 ?
@nelsonic nelsonic mentioned this issue Nov 19, 2016
Closed
nelsonic added a commit that referenced this issue Nov 20, 2016
@nelsonic
[WiP] add goodparts and start linting /lib see: #211
03ddcaf
nelsonic added a commit that referenced this issue Nov 23, 2016
@nelsonic
linting of lib/index.js (refactoring to use goodparts) complete. no c…
eb3d07d 
…hanges to tests. improvement in execution time! fixes #211
nelsonic added a commit that referenced this issue Nov 23, 2016
@nelsonic
update order of commands in pre-commit in package.json (includes lint…
2ec49ef 
…ing) #211
@nelsonic nelsonic mentioned this issue Nov 23, 2016
Merged
4 tasks
nelsonic added a commit that referenced this issue Nov 23, 2016
@nelsonic
lint code using goodparts see: #211 -> 100% backward compatible no fe…
7e0ae62 
…atures added/removed.
nelsonic added a commit that referenced this issue Nov 23, 2016
@nelsonic
lint code using goodparts see: #211 -> 100% backward compatible no fe…
f55e939 
…atures added/removed.
This was referenced Nov 23, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
nelsonic added a commit that referenced this issue Dec 4, 2016
@nelsonic
fix linting issue in lib/extract.js #211
b8999bf
This was referenced Dec 4, 2016
Merged
Merged
Merged
Merged
This was referenced Dec 4, 2016
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic