Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in /lib to conform to ESLint (JavaScript the Good Parts) #213

Merged
merged 4 commits into from
Nov 23, 2016

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Nov 23, 2016

Due to the lack of a Lint configuration the code had become inconsistent.
So this PR:

Not made any changes to the test(s) which confirms that this PR is a straight re-factor with no addition/loss of features (100% compatible) compared to previous version(s) of the plugin.

It wasn't this bad ...
image

But we needed something to tidy up the code.

The Good News is that with reduction in Cyclomatic Complexity (enforced by goodparts), the plugin runs marginally faster in our ("informal") benchmarks.

Thanks again to all the people who are using this plugin in their apps ✅
and especially to all who have contributed improvements! ❤️

image

image

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #213 into master will not change coverage

@@           master   #213   diff @@
====================================
  Files           2      2          
  Lines          94    108    +14   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits           94    108    +14   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 2c158ab...6eac431

@iteles
Copy link
Member

iteles commented Nov 23, 2016

This is some pretty impressive image usage for a PR description 😆 Do we want to also bump the version number?

@nelsonic
Copy link
Member Author

@iteles after the PR is merged I run the following command(s):

git checkout master
npm version patch -m 'lint code using goodparts see: https://github.com/dwyl/hapi-auth-jwt2/issues/211 -> 100% backward compatible no features added/removed.'
npm publish && git push && git push --tags

see: https://docs.npmjs.com/getting-started/publishing-npm-packages#updating-the-package

@iteles iteles merged commit a3300cc into master Nov 23, 2016
@iteles iteles deleted the refactor-to-goodparts branch November 23, 2016 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants