Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

230427 - Update 12px chevron icon and spacing #2053

Closed
ratinsl opened this issue Apr 28, 2023 · 4 comments
Closed

230427 - Update 12px chevron icon and spacing #2053

ratinsl opened this issue Apr 28, 2023 · 4 comments

Comments

@ratinsl
Copy link

ratinsl commented Apr 28, 2023

Hi All,

As you know we recently updated all the 12px icons that were using 16px artboards to now use 12px artboards. When making this update, the spacing between these updated icons and elements like text will appear "tighter" since the artboard got smaller. We need to go into a couple of components and make sure the spacing is adjusted so the new assets look correct.
The ticket that has the new 12px icons can be found here. The icons will need to be added before you can implement this ticket.

We will need to update the icon and spacing on the following (and anywhere else the 12px icons are used):

Please let me know if you have any questions,
Ryan Tinsley

@agliga agliga added this to eBayUI May 10, 2023
@agliga agliga added this to the 16.2.0 milestone May 10, 2023
@agliga agliga self-assigned this May 10, 2023
@agliga agliga modified the milestones: 16.2.0, 16.3.0 May 10, 2023
@agliga
Copy link
Contributor

agliga commented May 10, 2023

Possibly breaking, it might shift layout and sizes.

@agliga agliga removed their assignment May 10, 2023
@agliga agliga added this to the 17.0.0 milestone Sep 19, 2023
@agliga agliga moved this to Todo in eBayUI Sep 19, 2023
@ArtBlue
Copy link
Contributor

ArtBlue commented Dec 5, 2023

@ratinsl , it looks like the only change that is needed for this is for breadcrumbs.

1 - For breadcrumbs , the chevron margins were not aligned with the Figma spec. I updated to 6px margins from 3px.
2 and 3 - For the field dropdown and select, the current spacing already matches the Figma, so no change appears to be needed. See screenshot. In the code, the spacing already matches that.

Unless something is incorrect in the Figma, I'm going to simply ignore field and select.

image

@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Dec 5, 2023
@ratinsl
Copy link
Author

ratinsl commented Dec 8, 2023

@ArtBlue yes you are correct, looks like the one that was most impacted was the breadcrumbs one. So as long as you are matching the specs across these, then we are good!

@ArtBlue
Copy link
Contributor

ArtBlue commented Dec 8, 2023

@ArtBlue yes you are correct, looks like the one that was most impacted was the breadcrumbs one. So as long as you are matching the specs across these, then we are good!

Thanks! I'll move ahead with the breadcrumbs only spacing tweaks.

@ArtBlue ArtBlue moved this from In Progress to Pull request in eBayUI Dec 12, 2023
@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Dec 12, 2023
@agliga agliga closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants