Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons: additions, deletions, modifications #2035

Closed
ratinsl opened this issue Apr 7, 2023 · 4 comments
Closed

icons: additions, deletions, modifications #2035

ratinsl opened this issue Apr 7, 2023 · 4 comments
Assignees
Labels
module: icon priority: 3 Fix should be on roadmap or backlog
Milestone

Comments

@ratinsl
Copy link

ratinsl commented Apr 7, 2023

We have added some new icons to the system and have some updates and renames. The mapping spreadsheet has been updated with this ticket. Icons mentioned in notes below are in the attached zip folder.

[New Additions]

  • Search similar (16)
  • Pencil (20)
  • Sparkline Up (24, 20, 16)
  • Sparkline Down (24, 20, 16)
  • Location (16)
  • Key (24, 16)
  • Money Back Guarantee (24, 16) -this is part of the "new" badge system
  • Package (64)
  • Thumb Up (64)
  • Confirmation (64)
  • Notification (64)
  • eBay for Charity (24, 16)
  • Transaction (24)
  • eBay Preloved (24, 16)
  • Selling (16)
  • Undo (16)
  • Jet Ski (24, 16)
  • Snowmobile (24, 16)

[Updates]

  • Search similar (16)
  • Pencil (20)
  • eBay Refurbished (24, 16) -Is now the AG checkmark
  • Direct from Brand (24, 16) -Is now the AG checkmark
  • Brand Authorized Seller (24, 16) -Is now the AG checkmark
    Updated 12px icons to use 12px artboards:
  • arrow left 12
  • arrow right 12
  • chevron down 12
  • chevron left 12
  • chevron right 12
  • chevron up 12
  • sort 12
  • sort down 12
  • sort up 12

[Renames]
Removed currency- from the beginning of:

  • Dollar (24, 16)

  • Euro (24, 16)

  • Franc (24, 16)

  • Krona (24, 16)

  • Peso (24, 16)

  • Pound (24, 16)

  • Ringgit (24, 16)

  • Rupee (24, 16)

  • Zloty (24, 16)

  • Won (24, 16)

  • Yuan (24, 16)

  • Renamed “authenticity-guarantee-fit-” to “authenticity-guarantee-” (24, 16)

  • Renamed “brand-authorized-seller-fit-” (24, 16) to “brand-authorized-seller-” (24, 16)

    • Updated artwork to the AG checkmark
  • Renamed “direct-from-brand-fit-” (24, 16) to “direct-from-brand-” (24, 16)

    • Updated artwork to the AG checkmark
  • Renamed “certified-recycled-fit-” (24, 16) to “certified-recycled-” (24, 16)

  • Renamed “ebay-bucks-colored-16” to “ebay-bucks-logo-colored-16”

  • Renamed “ebay-international-shipping-fit-” (24, 16) to “ebay-international-shipping-” (24, 16)

  • Renamed “ebay-refurbished-fit-” (24, 16) to “ebay-refurbished-” (24, 16)

    • Updated artwork to the AG checkmark
  • Renamed “free-warranty-16-fit” to “free-warranty-16” -removed fit just on 16

  • Renamed “nectar-24-colored” to “nectar-logo-24-colored”

  • Renamed “rotate-landscape-left” to “rotate-landscape-left-24”

  • Renamed “rotate-landscape-right” to “rotate-landscape-right-24”

  • Renamed “rotate-portrait-left” to “rotate-portrait-left-24”

  • Renamed “rotate-portrait-right” to “rotate-portrait-right-24”

  • Renamed “pause-64-colored” to “pause-filled-64-colored”

  • Renamed “play-64-colored” to “play-filled-64-colored”

  • Renamed “top-rated-seller-16-fit” to “top-rated-seller-16”

  • Renamed “trend-up-16” to “trend-up-16-fit”

  • Renamed “trend-down-16” to “trend-down-16-fit”

  • Renamed “click-to-call-16-fit” to “click-to-call-16”

  • Renamed “priority- (16, 24, 64)” to “attention- (16, 24, 64)”

  • Renamed “priority-filled- (16, 24)” to “attention-filled- (16, 24)”

  • Renamed “arrow-title-20” to “arrow-right-20” and updated artwork

Removed social- from the beginning of:

  • Discord (24)

  • Facebook (24)

  • Facebook Messenger (24)

  • Instagram (24)

  • Link (24)

  • Linkedin (24)

  • Pinterest (24)

  • Reddit (24)

  • Twitter (24)

  • Whatsapp (24)

  • Renamed “arrow-title-20” to “arrow-right-20” and updated the artwork

Please let me know if you have any questions,
Ryan Tinsley

230606_Icon_Updates.zip

@ratinsl
Copy link
Author

ratinsl commented Apr 27, 2023

Hey @agliga and @ArtBlue this ticket is all updated. I will add add the corresponding icons to remove in the other ticket Andrew set up.

@ratinsl ratinsl changed the title 230406 - Icon Additions 230406 - Icon Updates Apr 29, 2023
@ArtBlue ArtBlue self-assigned this May 16, 2023
@ArtBlue ArtBlue added this to the 16.3.0 milestone May 16, 2023
@agliga agliga added module: icon priority: 3 Fix should be on roadmap or backlog labels May 17, 2023
@ArtBlue ArtBlue added this to eBayUI May 19, 2023
@ArtBlue ArtBlue moved this to Todo in eBayUI May 19, 2023
@ratinsl
Copy link
Author

ratinsl commented May 20, 2023

@agliga I added "undo 16" to this zip.

@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Jun 14, 2023
@ArtBlue
Copy link
Contributor

ArtBlue commented Jun 14, 2023

FYI, these change requests are unnecessary as they're already applied in prod:

  • Renamed “priority- (16, 24, 64)” to “attention- (16, 24, 64)”
  • Renamed “priority-filled- (16, 24)” to “attention-filled- (16, 24)”

@ArtBlue ArtBlue changed the title 230406 - Icon Updates icons: additions, deletions, modifications Jun 15, 2023
@ArtBlue ArtBlue moved this from In Progress to Pull request in eBayUI Jun 15, 2023
@ArtBlue
Copy link
Contributor

ArtBlue commented Jun 16, 2023

Per Ryan, we're also removing a couple of icons in lieu of their replacements,

  • play-filled-16 > play-filled-16-colored
  • play-filled-24 > play-filled-24-colored

@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Jun 16, 2023
@ArtBlue ArtBlue closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: icon priority: 3 Fix should be on roadmap or backlog
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants