fix(breadcrumbs): chevron icon spacing #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuLaValva
approved these changes
Dec 11, 2023
|
I don't see any new icons. I think the chevron icons the updated artboard need to be a part of this PR. |
saiponnada
approved these changes
Dec 11, 2023
| @@ -26,8 +26,8 @@ nav.breadcrumbs > ul > li[hidden] { | |||
| display: none; | |||
| } | |||
| nav.breadcrumbs > ul > li svg { | |||
| margin-left: 3px; | |||
| margin-right: 3px; | |||
| margin-left: 6px; | |||
There was a problem hiding this comment.
Minor suggestion, Can we use CSS variable var(--spacing-75) here?
Maybe I'm missing something, but... This PR is for this issue: #2053 That issue references this issue where the new 12px icons were added/updated: #2035 And that issue has the chevron updates: That was done in If there are no other links to yet other issues that I missed, I think we should be good. If the chevron icon issue is something separate and the icon is available somewhere I can't find, please let me know. |
ArtBlue
added a commit
that referenced
this pull request
Dec 27, 2023
agliga
pushed a commit
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2053
Description
Spacing adjustments with chevron on breadcrumbs.
Notes
The other components mentioned in the issue did not need spacing adjustments.
Screenshots
Before:
After:
Checklist