-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): additions, deletions, modifications #2083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The only change I would add (but we can do it post release), is to maybe have a deprecated section in the docs in the icons section, so that teams can see which ones are deprecated
Although, we should make use of that doc Ryan has (and maybe even link it out in our icon docs)
Either way, this PR is good to go as is
Good suggestions. I'll look into them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a quick fix for dark mode and a docs suggestion
* feat(icons): additions, deletions, modifications; addition of deprecated icons section in docs
Fixes #2035
Description
Various icon additions, deletions, modifications
Notes
I created a new
deprecated
section that skips docs to differentiate between icons that need to remain and will always need to be skipped from docs and those that will be removed entirely. This will help with the icons removal with the next major version. Upon deprecated icon file removals, the deprecated entries will be removed from the full list as well as deprecated section.Checklist