Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): additions, deletions, modifications #2083

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jun 15, 2023

Fixes #2035

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Various icon additions, deletions, modifications

Notes

I created a new deprecated section that skips docs to differentiate between icons that need to remain and will always need to be skipped from docs and those that will be removed entirely. This will help with the icons removal with the next major version. Upon deprecated icon file removals, the deprecated entries will be removed from the full list as well as deprecated section.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Jun 15, 2023
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The only change I would add (but we can do it post release), is to maybe have a deprecated section in the docs in the icons section, so that teams can see which ones are deprecated

Although, we should make use of that doc Ryan has (and maybe even link it out in our icon docs)

Either way, this PR is good to go as is

@ArtBlue
Copy link
Contributor Author

ArtBlue commented Jun 16, 2023

LGTM The only change I would add (but we can do it post release), is to maybe have a deprecated section in the docs in the icons section, so that teams can see which ones are deprecated

Although, we should make use of that doc Ryan has (and maybe even link it out in our icon docs)

Either way, this PR is good to go as is

Good suggestions. I'll look into them.

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a quick fix for dark mode and a docs suggestion

docs/_includes/icon.html Show resolved Hide resolved
docs/src/less/index.less Outdated Show resolved Hide resolved
@ArtBlue ArtBlue merged commit a151378 into 16.3.0 Jun 16, 2023
@ArtBlue ArtBlue deleted the icon-updates branch June 16, 2023 20:49
ArtBlue added a commit that referenced this pull request Jun 22, 2023
* feat(icons): additions, deletions, modifications; addition of deprecated icons section in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants