Add show and list commands #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-flagship
reviewed
Nov 2, 2022
Comment on lines
+20
to
+23
| if (flags.owner) { | ||
| const owner = normalizeHex(flags.owner); | ||
| data = data.filter((value: { owner: string }) => value.owner.toLowerCase() === owner.toLowerCase()); | ||
| } |
There was a problem hiding this comment.
Since the contract isn't implementing this filter, feels like the results might be unexpected when using the pagination flags.
If the contract data was: projects = [ownerA, ownerB] and the user ran armada project list --owner ownerB --size 1, this implementation would return an empty result.
Given that, I wonder if we should just drop the filter... let people pipe into jq if they need it?
There was a problem hiding this comment.
This should be fixed in #18
There was a problem hiding this comment.
Can this go in now, or do you think this flags needs to be removed until #18 is in?
There was a problem hiding this comment.
I'm not bothered by what order things happen as we're refactoring pretty rapidly
the-flagship
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.