Implement proper paging of results #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares for adding more signers such as multisig and hex raw.
the-flagship
requested changes
Nov 2, 2022
Add flag for signer method
the-flagship
approved these changes
Nov 2, 2022
| console.log(normalizeRecords(records)); | ||
| const blockTag = await provider.getBlockNumber(); | ||
| const results: Result[] = await getAll(flags.page, async (i, n) => { | ||
| return await nodes.getNodes(operatorId, flags.topology, i, n, { blockTag }); |
There was a problem hiding this comment.
nit: I don't think you need this await
There was a problem hiding this comment.
FYI correct - it's not required, just more explicit
| const owner = normalizeHex(flags.owner); | ||
| const blockTag = await provider.getBlockNumber(); | ||
| let results: Result[] = await getAll(flags.page, async (i, n) => { | ||
| return await projects.getProjects(i, n, { blockTag }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.