Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(footer): update eu footer links - FRONT-4394 #3387

Merged
merged 3 commits into from
May 22, 2024
Merged

feat(footer): update eu footer links - FRONT-4394 #3387

merged 3 commits into from
May 22, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented May 14, 2024 •
edited
Loading

  • update links to have the full label clickable
  • update font size for footer titles

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

🚀 Deployed on https://ecl-preview-3387--europa-component-library.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 06:49 Inactive
@planctus planctus self-requested a review May 14, 2024 08:25
planctus
planctus reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update links to have the full line clickable

Just a question, was this foreseen and then the request has changed? The links are inline so only their label is clickable..

@emeryro
Copy link
Contributor Author

emeryro commented May 14, 2024

this was wrongly written. It is not the full line clickable, but the full label (there were some standard text before)

@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 11:28 Inactive
@planctus planctus self-requested a review May 14, 2024 12:11
@github-actions github-actions bot temporarily deployed to pull request May 22, 2024 08:10 Inactive
@emeryro emeryro merged commit d52335a into v4-dev May 22, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4394-eu-footer branch May 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planctus planctus planctus approved these changes

Assignees
No one assigned
Labels
tag: data change tag: enhancement tag: markup changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emeryro @planctus