Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(footer): update eu footer links - FRONT-4394 #3387

Merged
merged 3 commits into from
May 22, 2024
Merged

feat(footer): update eu footer links - FRONT-4394 #3387

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09f5eb6
update eu footer
emeryro May 14, 2024
7d96d82
update line height
emeryro May 14, 2024
1f041a3
Merge branch 'v4-dev' into FRONT-4394-eu-footer
emeryro May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 11 additions & 31 deletions src/implementations/twig/components/site-footer/__snapshots__/site-footer.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,49 +1083,41 @@ exports[`Site Footer Core EU renders correctly 1`] = `
<li
class="ecl-site-footer__list-item"
>

Call us
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="tel:0080067891011"
>
00 800 6 7 8 9 10 11
Call us 00 800 6 7 8 9 10 11
</a>
</li>
<li
class="ecl-site-footer__list-item"
>

Use other
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="https://european-union.europa.eu/contact-eu/call-us_en"
>
telephone options
Use other telephone options
</a>
</li>
<li
class="ecl-site-footer__list-item"
>

Write us via our
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="https://european-union.europa.eu/contact-eu/write-us_en"
>
contact form
Write us via our contact form
</a>
</li>
<li
class="ecl-site-footer__list-item"
>

Meet us at one of the
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="https://european-union.europa.eu/contact-eu/meet-us_en"
>
EU centres
Meet us at one of the EU centres
</a>
</li>
</ul>
Expand All @@ -1144,13 +1136,11 @@ exports[`Site Footer Core EU renders correctly 1`] = `
<li
class="ecl-site-footer__list-item"
>

Search for
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="https://european-union.europa.eu/contact-eu/social-media-channels_en"
>
EU social media channels
Search for EU social media channels
</a>
</li>
</ul>
Expand Down Expand Up @@ -1706,7 +1696,7 @@ exports[`Site Footer Harmonised EU renders correctly 1`] = `
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="/example"
>
Accessibility
Accessibility statement
</a>
</li>
</ul>
Expand Down Expand Up @@ -1938,49 +1928,41 @@ exports[`Site Footer Harmonised EU renders correctly 1`] = `
<li
class="ecl-site-footer__list-item"
>

Call us
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="/example"
>
00 800 6 7 8 9 10 11
Call us 00 800 6 7 8 9 10 11
</a>
</li>
<li
class="ecl-site-footer__list-item"
>

Use other
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="/example"
>
telephone options
Use other telephone options
</a>
</li>
<li
class="ecl-site-footer__list-item"
>

Write us via our
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="/example"
>
contact form
Write us via our contact form
</a>
</li>
<li
class="ecl-site-footer__list-item"
>

Meet us at one of the
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="/example"
>
EU centres
Meet us at one of the EU centres
</a>
</li>
</ul>
Expand All @@ -1999,13 +1981,11 @@ exports[`Site Footer Harmonised EU renders correctly 1`] = `
<li
class="ecl-site-footer__list-item"
>

Search for
<a
class="ecl-link ecl-link--standalone ecl-site-footer__link"
href="/example"
>
EU social media channels
Search for EU social media channels
</a>
</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion src/implementations/vanilla/components/site-footer/site-footer-eu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ $site-footer: null !default;

.ecl-site-footer__title {
color: map.get($site-footer, 'color');
font: var(--f-2xl);
font: var(--f-l);
margin: 0;
}

Expand Down
15 changes: 5 additions & 10 deletions src/specs/components/site-footer/demo/data-core--eu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,30 +24,26 @@ module.exports = {
title_with_separator: true,
links: [
{
content_before: 'Call us ',
link: {
label: '00 800 6 7 8 9 10 11',
label: 'Call us 00 800 6 7 8 9 10 11',
path: 'tel:0080067891011',
},
},
{
content_before: 'Use other ',
link: {
label: 'telephone options',
label: 'Use other telephone options',
path: 'https://european-union.europa.eu/contact-eu/call-us_en',
},
},
{
content_before: 'Write us via our ',
link: {
label: 'contact form',
label: 'Write us via our contact form',
path: 'https://european-union.europa.eu/contact-eu/write-us_en',
},
},
{
content_before: 'Meet us at one of the ',
link: {
label: 'EU centres',
label: 'Meet us at one of the EU centres',
path: 'https://european-union.europa.eu/contact-eu/meet-us_en',
},
},
Expand All @@ -58,9 +54,8 @@ module.exports = {
title_with_separator: true,
links: [
{
content_before: 'Search for ',
link: {
label: 'EU social media channels',
label: 'Search for EU social media channels',
path: 'https://european-union.europa.eu/contact-eu/social-media-channels_en',
},
},
Expand Down
17 changes: 6 additions & 11 deletions src/specs/components/site-footer/demo/data-harmonised--eu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module.exports = {
links: [
{
link: {
label: 'Accessibility',
label: 'Accessibility statement',
path: exampleLink,
},
},
Expand Down Expand Up @@ -134,30 +134,26 @@ module.exports = {
title_with_separator: true,
links: [
{
content_before: 'Call us ',
link: {
label: '00 800 6 7 8 9 10 11',
label: 'Call us 00 800 6 7 8 9 10 11',
path: exampleLink,
},
},
{
content_before: 'Use other ',
link: {
label: 'telephone options',
label: 'Use other telephone options',
path: exampleLink,
},
},
{
content_before: 'Write us via our ',
link: {
label: 'contact form',
label: 'Write us via our contact form',
path: exampleLink,
},
},
{
content_before: 'Meet us at one of the ',
link: {
label: 'EU centres',
label: 'Meet us at one of the EU centres',
path: exampleLink,
},
},
Expand All @@ -168,9 +164,8 @@ module.exports = {
title_with_separator: true,
links: [
{
content_before: 'Search for ',
link: {
label: 'EU social media channels',
label: 'Search for EU social media channels',
path: exampleLink,
},
},
Expand Down
Loading