Clarifications in monitoring chapter #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
approved these changes
Dec 23, 2019
benoitf
reviewed
Dec 23, 2019
src/main/pages/che-7/administration-guide/assembly_monitoring-che.adoc
Outdated
Show resolved
Hide resolved
skabashnyuk
reviewed
Dec 23, 2019
…che.adoc Co-Authored-By: Florent BENOIT <[email protected]>
…posing che metrics
|
It is not clear to me where to find the I found this file, but as far as I understand, this file is not referencing Grafana: https://github.com/redhat-developer/che-monitoring/blob/master/openshift/che-monitoring.yaml |
|
I will merge this PR as it is. We need more input to get further, but it is already in a better state now. |
themr0c
added a commit
that referenced
this pull request
Dec 23, 2019
* build-docker-image also with podman (#983) * build-docker-image also with podman * new container is on quay.io/eclipse/che-docs * rework building a custom registry image (#998) * rework building a custom registry image * fix missing EOF * refresh ref_che-theia-plug-in-metadata with updated content (#963) * refresh ref_che-theia-plug-in-metadata with updated content * fixes to address @AndrienkoAleksandr comments * Update git SSL docs (#1001) * use new container image for devfile - fixes eclipse-che/che/issues/15546 (#1002) * Clarifications in monitoring chapter (#1000) * Clarifications in monitoring chapter * Update src/main/pages/che-7/administration-guide/assembly_monitoring-che.adoc Co-Authored-By: Florent BENOIT <[email protected]> * handle feedback from @skabashnyuk - add visibility to enabling and exposing che metrics * rework Viewing Che metrics on Grafana dashboards Co-authored-by: Florent BENOIT <[email protected]> Co-authored-by: Igor Vinokur <[email protected]> Co-authored-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize the chapter.
Rewrite the Prometheus part.