Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

che-docs devfile doesn't include runtime container that can run docker, podman, or mvn #15546

Closed
1 task done
nickboldt opened this issue Dec 19, 2019 · 1 comment · Fixed by eclipse-che/che-docs#1002
Closed
1 task done

che-docs devfile doesn't include runtime container that can run docker, podman, or mvn #15546

nickboldt opened this issue Dec 19, 2019 · 1 comment · Fixed by eclipse-che/che-docs#1002
Assignees
@nickboldt @themr0c @rkratky
Labels
area/doc Issues related to documentation kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Dec 19, 2019 •
edited
Loading

Describe the bug

When I load the che-docs devfile, I can see sources, but I can't run any of the build scripts.

So we need to improve the che-docs runtime so it's got more than just jekyll in it:

image

Che version

  • 7.3.2 che.openshift.io

Steps to reproduce

Load this devfile:

https://che.openshift.io/dashboard/#/load-factory/?url=https://raw.githubusercontent.com/eclipse/che-docs/master/devfile.yaml

When I loaded it the second time, I got commands I could run but the jekyll based build che-docs [1] command failed:

image

[1] https://raw.githubusercontent.com/eclipse/che-docs/master/devfile.yaml
@nickboldt nickboldt added the kind/bug Outline of a bug - must adhere to the bug report template. label Dec 19, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 19, 2019
@tolusha tolusha added area/doc Issues related to documentation team/doc severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 20, 2019
@themr0c
Copy link
Contributor

themr0c commented Dec 23, 2019

Looking into it.

Seems we forgot to update the devfile when updating the image for quay.io/eclipse/che-docs.

@themr0c themr0c mentioned this issue Dec 23, 2019
Merged
themr0c added a commit to eclipse-che/che-docs that referenced this issue Dec 23, 2019
@themr0c
use new container image for devfile - fixes eclipse-che/che/issues/15546
40fb6b1 
 (#1002)
themr0c added a commit to eclipse-che/che-docs that referenced this issue Dec 23, 2019
@themr0c @vinokurig @benoitf
Backport master to 7.3.x (#1003)
2e8cb30 
* build-docker-image also with podman (#983)

* build-docker-image also with podman

* new container is on quay.io/eclipse/che-docs

* rework building a custom registry image (#998)

* rework building a custom registry image

* fix missing EOF

* refresh ref_che-theia-plug-in-metadata with updated content (#963)

* refresh ref_che-theia-plug-in-metadata with updated content

* fixes to address @AndrienkoAleksandr  comments

* Update git SSL docs (#1001)

* use new container image for devfile - fixes eclipse-che/che/issues/15546 (#1002)

* Clarifications in monitoring chapter (#1000)

* Clarifications in monitoring chapter

* Update src/main/pages/che-7/administration-guide/assembly_monitoring-che.adoc

Co-Authored-By: Florent BENOIT <[email protected]>

* handle feedback from @skabashnyuk - add visibility to enabling and exposing che metrics

* rework Viewing Che metrics on Grafana dashboards

Co-authored-by: Florent BENOIT <[email protected]>

Co-authored-by: Igor Vinokur <[email protected]>
Co-authored-by: Florent BENOIT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickboldt nickboldt

@themr0c themr0c

@rkratky rkratky

Labels
area/doc Issues related to documentation kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use latest container image for devfile
5 participants
@nickboldt @themr0c @tolusha @rkratky @che-bot