Restore some loader.waitOnClosed() calls #11348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
requested review from
dmytro-ndp,
musienko-maxim and
Ohrimenko1988
as code owners
tolusha
approved these changes
Sep 25, 2018
benoitf
added
target/branch
benoitf
removed
the
status/code-review
tsmaeder
added a commit
that referenced
this pull request
Sep 26, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 1, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 5, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 12, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 16, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores some calls to loader.waitOnClosed() in project explorer to make sure they are not the reason for failures.
What issues does this PR fix or reference?
none