Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore some loader.waitOnClosed() calls #11348

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Restore some loader.waitOnClosed() calls #11348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ProjectExplorer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,8 @@ public void waitItem(String path) {
* @param timeout waiting timeout in seconds
*/
public void waitItem(String path, int timeout) {
loader.waitOnClosed();

seleniumWebDriverHelper.waitVisibility(
By.xpath(format(PROJECT_EXPLORER_ITEM_TEMPLATE, path)), timeout);
}
Expand All @@ -301,6 +303,8 @@ public void waitItem(String path, int timeout) {
* @param reference git reference e.g. branch, tag or commit
*/
public void waitReferenceName(String reference) {
loader.waitOnClosed();

seleniumWebDriverHelper.waitTextEqualsTo(projectReference, "(" + reference + ")");
}

Expand Down Expand Up @@ -440,6 +444,8 @@ public List<WebElement> waitVisibilitySeveralItemsByName(String... names) {
* @return found {@link WebElement}
*/
public WebElement waitVisibilityByName(String name, int timeOut) {
loader.waitOnClosed();

return seleniumWebDriverHelper.waitVisibility(
By.xpath(format("//div[@id='gwt-debug-projectTree']//div[text()='%s']", name)), timeOut);
}
Expand Down Expand Up @@ -610,6 +616,7 @@ public void waitDisappearItemByPath(String path) {
* @param folderType folder's type, defined in {@link FolderTypes}
*/
public void waitDefinedTypeOfFolder(String path, FolderTypes folderType) {
loader.waitOnClosed();
seleniumWebDriverHelper.waitVisibility(
By.xpath(
format(
Expand Down