Issue 1793: Language Server Protocol: ShowMessage Notification feature #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1070/ |
|
@evidolob |
vparfonov
reviewed
Nov 29, 2016
| @@ -93,4 +93,5 @@ | |||
| <!-- Specify the paths for translatable code --> | |||
| <source path='client'/> | |||
| <source path='shared'/> | |||
| <collapse-all-properties /> | |||
There was a problem hiding this comment.
What the reason add collapse-all-properties? Did you get real performance improvement?
There was a problem hiding this comment.
right, I need to remove that line. I added it as part of the trick to reduce the build time during dev, but this should not have been included in this patch.
There was a problem hiding this comment.
@vparfonov I just pushed an update of the patch in which I removed this extra-line.
Added a ShowMessageProcessor and a ShowMessageMessager classes to process incoming `window/showMessage` notification and display a notification in `float` mode in the UI if the message type is `error` or `warning`, in the events panel otherwise. Note that the notification type for `error` messages is incorrectly set to `Log` because of a bug in the typefox dependency: `io.typefox.lsapi.MessageType#Log` has the value `1` instead of `4`. This issue depends on #3113 (Add a 'warning' state for the notifications) To test the pull request, please follow the instructions on #3123 to run the 'test-lang' server. Once in the workspace, create a project, add a `foo.test` file (the Language Server support for the 'test-lang' will be activated), then type the following line > window/showMessage:error: a message and wait for the editor to save the changes. This will trigger a `window/showMessage` notification from the 'test-lang' server in the Che UI. Signed-off-by: Xavier Coulon <[email protected]>
vparfonov
approved these changes
Dec 5, 2016
tolusha
approved these changes
Dec 5, 2016
|
great, thanks! |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
eclipse-che#3124) Added a ShowMessageProcessor and a ShowMessageMessager classes to process incoming `window/showMessage` notification and display a notification in `float` mode in the UI if the message type is `error` or `warning`, in the events panel otherwise. Note that the notification type for `error` messages is incorrectly set to `Log` because of a bug in the typefox dependency: `io.typefox.lsapi.MessageType#Log` has the value `1` instead of `4`. This issue depends on eclipse-che#3113 (Add a 'warning' state for the notifications) To test the pull request, please follow the instructions on eclipse-che#3123 to run the 'test-lang' server. Once in the workspace, create a project, add a `foo.test` file (the Language Server support for the 'test-lang' will be activated), then type the following line > window/showMessage:error: a message and wait for the editor to save the changes. This will trigger a `window/showMessage` notification from the 'test-lang' server in the Che UI. Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a ShowMessageProcessor and a ShowMessageMessager classes to process
incoming
window/showMessagenotification and display a notificationin
floatmode in the UI if the message type iserrororwarning, inthe events panel otherwise. Note that the notification type for
errormessages is incorrectly set to
Logbecause of a bug in the typefoxdependency:
io.typefox.lsapi.MessageType#Loghas the value1instead of4.This issue depends on #3113
(Add a 'warning' state for the notifications)
To test the pull request, please follow the instructions on
#3123 to run the 'test-lang' server.
Once in the workspace, create a project, add a
foo.testfile (theLanguage Server support for the 'test-lang' will be activated), then
type the following line
and wait for the editor to save the changes. This will trigger a
window/showMessagenotification from the 'test-lang' server in the Che UI.What issues does this PR fix or reference?
Issue #1793
Signed-off-by: Xavier Coulon [email protected]